Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.7.3) - Weather variability config logging in CSVLogger wrapper #466

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

AlejandroCN7
Copy link
Member

Description

This pull request includes several changes to add weather variability configuration logging, update version numbers, and improve test coverage. The most important changes are grouped into three themes: logging enhancements, version updates, and test improvements.

Logging Enhancements:

  • Added weather_variability_config.json to the output directory to log weather variability configurations for each episode.
  • Introduced weather_variability_config attribute in modeling.py to store weather variability configurations.
  • Updated apply_weather_variability method to assign variability configurations to self.weather_variability_config.
  • Added weather_variability_config_path in wrappers.py and updated dump_log_files method to log weather variability configurations if they exist. [1] [2]

Version Updates:

  • Updated the version from 3.7.2 to 3.7.3 in pyproject.toml and version.txt. [1] [2]

Test Improvements:

  • Modified test_apply_weather_variability to remove checks for the existence of weather_variability_config.json.
  • Enhanced test_CSVlogger_wrapper to include parameterized tests for different environments and to check the creation of weather_variability_config_path. [1] [2] [3]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

@AlejandroCN7 AlejandroCN7 merged commit 2902239 into main Jan 27, 2025
5 checks passed
@AlejandroCN7 AlejandroCN7 deleted the feat/weather-var_log branch January 27, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant