(v3.7.3) - Weather variability config logging in CSVLogger wrapper #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to add weather variability configuration logging, update version numbers, and improve test coverage. The most important changes are grouped into three themes: logging enhancements, version updates, and test improvements.
Logging Enhancements:
weather_variability_config.json
to the output directory to log weather variability configurations for each episode.weather_variability_config
attribute inmodeling.py
to store weather variability configurations.apply_weather_variability
method to assign variability configurations toself.weather_variability_config
.weather_variability_config_path
inwrappers.py
and updateddump_log_files
method to log weather variability configurations if they exist. [1] [2]Version Updates:
3.7.2
to3.7.3
inpyproject.toml
andversion.txt
. [1] [2]Test Improvements:
test_apply_weather_variability
to remove checks for the existence ofweather_variability_config.json
.test_CSVlogger_wrapper
to include parameterized tests for different environments and to check the creation ofweather_variability_config_path
. [1] [2] [3]Types of changes
Checklist:
autopep8
second level aggressive.isort
.cd docs && make spelling && make html
pass (required if documentation has been updated.)pytest tests/ -vv
pass. (required).pytype -d import-error sinergym/
pass. (required)