Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.2.8) - RBC with fixed setpoint values #401

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Conversation

AlejandroCN7
Copy link
Member

Description

The controller in datacenter has been renamed to be called incremental, then a RBC for datacenter has been created with fixed setpoint values to have one equivalent to the 5-zone RBC.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • RBCDatacenter renamed to RBCIncrementalDatacenter, then created RBCDatacenter with fixed setpoint values.
  • Updated controller tests

@AlejandroCN7 AlejandroCN7 merged commit b4052e2 into main Mar 26, 2024
5 checks passed
@AlejandroCN7 AlejandroCN7 deleted the feat/rbc-datacenter branch March 26, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant