Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.2.7) - 5Zone building design improved for thermal control #397

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

Ahmed2BP
Copy link
Collaborator

@Ahmed2BP Ahmed2BP commented Mar 8, 2024

Description

The amount of outdoor air in 5Zone building has been reduced to improve agent's control. As mentioned in #396, agent's performance is limited due to building design, as it was not able to keep indoor temperature in the desired ranges. By reducing the amount of air taken from outside, the HVAC system is now able to meet temperature requirements.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Fixes #396

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • A scheduler has been modified in 5Zone building to reduce the outdoor air flow rate.
  • 5Zone building action space ranges are adjusted to let the agent meet temperature requirements.
  • 5Zone default RBC's setpoints are modified to match temperature requirements.
  • Sinergym version has been updated.

@Ahmed2BP Ahmed2BP added the building Buildings (IDF, EPW) label Mar 13, 2024
@AlejandroCN7 AlejandroCN7 self-requested a review March 13, 2024 09:47
Copy link
Member

@AlejandroCN7 AlejandroCN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you very much for the improvements :)

@AlejandroCN7 AlejandroCN7 merged commit b7f0545 into main Mar 13, 2024
5 checks passed
@AlejandroCN7 AlejandroCN7 deleted the bug/issue-396 branch March 13, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Buildings (IDF, EPW)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Significant limitations in 5Zone building control.
2 participants