Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cbor: use fmtTime instead of time.Format for RFC3339Nano #394

Closed
wants to merge 1 commit into from
Closed

cbor: use fmtTime instead of time.Format for RFC3339Nano #394

wants to merge 1 commit into from

Conversation

extemporalgenome
Copy link
Contributor

This may save an allocation per string-formatted timestamp,
particularly by reusing a byte slice from blist.

@extemporalgenome
cbor: use fmtTime instead of time.Format for RFC3339Nano
caa71e3 
This may save an allocation per string-formatted timestamp,
particularly by reusing a byte slice from blist.
ugorji
ugorji reviewed Nov 28, 2023
View reviewed changes
Copy link
Owner

@ugorji ugorji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the change, but considering adding a []byte to the cborEncoder, to avoid work to get small byte array for time formatting.

@ugorji ugorji closed this in 1acedc2 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ugorji ugorji ugorji left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@extemporalgenome @ugorji