Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atmospheric model's field import #848

Merged
merged 11 commits into from
Oct 5, 2021

Conversation

rmontuoro
Copy link
Collaborator

@rmontuoro rmontuoro commented Oct 4, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR fixes the coupling issue described in #401, which occurs when running the atmospheric model's with separate run phases.

Issue(s) addressed

Testing

These changes were tested on the following platforms:

Dependencies

@rmontuoro rmontuoro changed the title Point FV3 submodule to forked repository. Fix atmospheric model's field import Oct 4, 2021
@climbfuji
Copy link
Collaborator

@BrianCurtis-NOAA @junwang-noaa I removed the Cheyenne labels so that they won't overwrite my logs once Brian fixed the problem.

@BrianCurtis-NOAA
Copy link
Collaborator

Note: Cheyenne missing a file in AutoRT, issue fixed.

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: RT
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/749037300/20211004140010/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_367581
Test cpld_control_c192_p7 006 failed failed
Test cpld_control_c192_p7 006 failed in run_test failed
Please make changes and add the following label back:
orion-intel-RT

@MinsukJi-NOAA
Copy link
Contributor

MinsukJi-NOAA commented Oct 5, 2021

Automated RT Failure Notification Machine: orion Compiler: intel Job: RT Repo location: /work/noaa/nems/emc.nemspara/autort/pr/749037300/20211004140010/ufs-weather-model Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_367581 Test cpld_control_c192_p7 006 failed failed Test cpld_control_c192_p7 006 failed in run_test failed Please make changes and add the following label back: orion-intel-RT

cpld_control_c192_p7 timed out. Will manually run cpld_control_c192_p7 and cpld_restart_c192_p7

@MinsukJi-NOAA
Copy link
Contributor

@rmontuoro , can you please run regression tests on Cray and Dell?

@junwang-noaa
Copy link
Collaborator

Venus has a bad network switch. the RT does not get identical results from mars. We will skip dell RT for this PR.

@climbfuji
Copy link
Collaborator

fv3atm was merged, new hash is 95ff1ca

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve after .gitmodules and submodule pointer update.

@climbfuji climbfuji merged commit aa95c12 into ufs-community:develop Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
6 participants