-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CMEPS to allow CICE6 albedos -> ATM #708
Merged
DeniseWorthen
merged 71 commits into
ufs-community:develop
from
DeniseWorthen:feature/add_albedos
Jul 28, 2021
Merged
Update CMEPS to allow CICE6 albedos -> ATM #708
DeniseWorthen
merged 71 commits into
ufs-community:develop
from
DeniseWorthen:feature/add_albedos
Jul 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry everyone. I forgot to update the BLDATE. |
junwang-noaa
approved these changes
Jul 28, 2021
All RTs are complete and gitmodules have been update. Ready to merge. @BrianCurtis-NOAA can you please review? |
BrianCurtis-NOAA
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed hash's as well. Looks good.
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
Update the workflow to use the pre-combined point source data files (NOAA-EMC/AQM-utils#4) in order to reduce runtime for Online-CMAQ with explicit point source on. This is a breaking change (if using explicit point source) since the invocation of the point source data merge tool has changed slightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Baseline Updates
Current baselines will be updated.
Waiting for Reviews
The PR is waiting for reviews from associated component PR's.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Updates CMEPS to allow CICE6 albedos to be exported to ATM
Issue(s) addressed
Issue #700
Testing
Testing on Hera.intel and gnu (coupled and datm/cdeps RTs only) shows that new baselines will be required for coupled tests because of the additional albedo fields present in the coupler restart file. All other files compared for coupled tests are B4B.
RegressionTests_hera.gnu.log
RegressionTests_hera.intel.log
The control_c192 regression test was run for 5 days and the mediator history files were written at each pass through the fast coupling loop. The following figure shows the 4 components of albedo exported to the ATM at approximately 180E,78N on tile 3:
The following figure shows the 4 components of albedo exported to the ATM at approximately 20E,65S on tile 6:
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
CMEPS PR #55