Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hourly maximum precipitation rate #641

Merged
merged 15 commits into from
Jun 16, 2021
Merged

Add hourly maximum precipitation rate #641

merged 15 commits into from
Jun 16, 2021

Conversation

ericaligo-NOAA
Copy link
Collaborator

@ericaligo-NOAA ericaligo-NOAA commented Jun 15, 2021

Ready for review

PR Checklist

#576

Only standalone model (regional configurations) should include a new field in the diag_table:
"gfs_phys", "pratemax", "pratemax", "fv3_history2d", "all", .false., "none", 2

Description

This PR adds the hourly maximum precipitation rate in mm/hr for all microphysical schemes and will be used only by regional configurations. Results for regional configurations will change because pratemax, as noted above, will be added to the diag_table. Global configurations will not use pratemax, therefore, results would be unchanged.

Issue(s) addressed

#576

Testing

Tested on hera with intel. New baseline was created for the regional configuration and a 2nd RT was run to confirm bit identical results. For global applications, no new baseline was created and results were bit identical.

  • hera.intel
  • hera.gnu
  • orion.intel - skip, not enough resources on Orion at this moment
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI

Dependencies

fv3atm,ccpp/physics
NOAA-EMC/fv3atm#327
NCAR/ccpp-physics#675

@junwang-noaa junwang-noaa added Baseline Updates Current baselines will be updated. New Input Data Req'd This PR requires new data to be sync across platforms cheyenne-gnu-BL labels Jun 15, 2021
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericaligo-NOAA please update input data directory to input-data-20210614 and BL_DATE. both in rt.sh

@DusanJovic-NOAA DusanJovic-NOAA changed the title update fv3 Add hourly maximum precipitation rate Jun 15, 2021
@MinsukJi-NOAA
Copy link
Contributor

@DusanJovic-NOAA
Copy link
Collaborator

Two tests (regional_quilt and regional_quilt_RRTMGP) failed to verify against new baselines on WCOSS Cray:

baseline dir = /gpfs/hps3/emc/nems/noscrub/emc.nemspara/RT/NEMSfv3gfs/develop-20210615/fv3_regional_quilt
working dir  = /gpfs/hps3/stmp/Dusan.Jovic/FV3_RT/rt_25546/regional_quilt
Checking test 021 regional_quilt results ....
 Comparing dynf000.nc .........OK
 Comparing dynf024.nc .........OK
 Comparing phyf000.nc .........OK
 Comparing phyf024.nc .........OK
 Comparing PRSLEV.GrbF00 .........NOT OK
 Comparing PRSLEV.GrbF24 .........NOT OK
 Comparing NATLEV.GrbF00 .........NOT OK
 Comparing NATLEV.GrbF24 .........NOT OK

The total amount of wall time                        = 344.456499

Test 021 regional_quilt FAIL


baseline dir = /gpfs/hps3/emc/nems/noscrub/emc.nemspara/RT/NEMSfv3gfs/develop-20210615/fv3_regional_quilt_RRTMGP
working dir  = /gpfs/hps3/stmp/Dusan.Jovic/FV3_RT/rt_25546/regional_quilt_RRTMGP
Checking test 024 regional_quilt_RRTMGP results ....
 Comparing dynf000.nc .........OK
 Comparing dynf024.nc .........OK
 Comparing phyf000.nc .........OK
 Comparing phyf024.nc .........OK
 Comparing PRSLEV.GrbF00 .........NOT OK
 Comparing PRSLEV.GrbF24 .........NOT OK
 Comparing NATLEV.GrbF00 .........NOT OK
 Comparing NATLEV.GrbF24 .........NOT OK

The total amount of wall time                        = 434.963466

Test 024 regional_quilt_RRTMGP FAIL

@BrianCurtis-NOAA
Copy link
Collaborator

Machine: orion
Compiler: intel
Job: BL
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/670000650/20210615090017/ufs-weather-model
Please make changes and add the following label back:
orion-intel-BL

@BrianCurtis-NOAA
Copy link
Collaborator

Orion jobs are still pending. I do not know why it posted here.

@DusanJovic-NOAA DusanJovic-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's. and removed Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Jun 16, 2021
@DusanJovic-NOAA DusanJovic-NOAA merged commit f69af71 into ufs-community:develop Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. New Input Data Req'd This PR requires new data to be sync across platforms Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants