-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/P7b: set up P7b test case #636
Merged
junwang-noaa
merged 4 commits into
ufs-community:release/P7b
from
junwang-noaa:p7b_phys
Jun 14, 2021
Merged
release/P7b: set up P7b test case #636
junwang-noaa
merged 4 commits into
ufs-community:release/P7b
from
junwang-noaa:p7b_phys
Jun 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No, they are additional files needed for the gwd_opt option used by ugwdv1.
…On Fri, Jun 11, 2021 at 3:08 PM Denise Worthen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/fv3_conf/cpld_bmark_tiled_run.IN
<#636 (comment)>
:
> +#merra2
+if [ $IAER = 1011 ]; then
+ for n in 01 02 03 04 05 06 07 08 09 10 11 12; do
+ cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/MERRA2/merra2.aerclim.2003-2014.m${n}.nc aeroclim.m${n}.nc
+ done
+ cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/aer_data/LUTS/optics_BC.v1_3.dat optics_BC.dat
+ cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/aer_data/LUTS/optics_OC.v1_3.dat optics_OC.dat
+ cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/aer_data/LUTS/optics_DU.v15_3.dat optics_DU.dat
+ cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/aer_data/LUTS/optics_SS.v3_3.dat optics_SS.dat
+ cp @[INPUTDATA_ROOT]/FV3_input_data_INCCN_aeroclim/aer_data/LUTS/optics_SU.v1_3.dat optics_SU.dat
+fi
+
+#ugwpv1
+if [ $DO_UGWP_V1 = .true. ]; then
+ cp @[INPUTDATA_ROOT]/FV3_input_data/ugwp_c384_tau.nc ./ugwp_limb_tau.nc
+ cp @[INPUTDATA_ROOT]/FV3_input_datac384/INPUT_L127/oro_data_ls* ./INPUT
So these oro_data_ls* files are meant to optionally over-write the
oro_data.tileX.nc files which are copied in at LN 34-40?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#636 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TJPZIHKO5BVMOM7FYTTSJNLFANCNFSM46RGIBJA>
.
|
Yes, I am first testing the cpld_bmark_wave_v16_p7b, once it works I will
add the related changes in rt_35d.conf
…On Fri, Jun 11, 2021 at 4:35 PM Denise Worthen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/tests/cpld_bmark_wave_v16_p7b_35d
<#636 (comment)>
:
> @@ -0,0 +1,163 @@
+#
We'll need to add this 35d test to the rt_35d.conf along w/ adding the
suite to the compile line there. But you may still be making
changes/testing things?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#636 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TM72KPMWAFIBELZFA3TSJXRNANCNFSM46RGIBJA>
.
|
DeniseWorthen
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run scripts look good
@AvichalMehra-NOAA @yangfanglin The P7b branch has all the required features specified in the prototype documents. |
@junwang-noaa Thanks. We need to verify that all looks good with P7a. |
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
This PR is to add ccpp p7b suite file and update regression test script for the atmosphere physics namelist/input data in order to run P7b.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).