Ufs weather model for pr

[SMoorthi-emc]

PR Checklist

• Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

• This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

• An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
  are specified below.

• If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

• fixes #<issue_number>
• fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

• hera.intel
• hera.gnu
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss_cray
• wcoss_dell_p3

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

• CCPP-Physics Pull request Sm may182021 #662
• fv3atm full request may182021 #303

[junwang-noaa]

I think it's this script for module purge. source $PATHTR/NEMS/src/conf/module-setup.sh.inc

…

On Wed, Jun 2, 2021 at 3:54 PM Dom Heinzeller ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tests/compile.sh <#606 (comment)> : > @@ -54,6 +54,7 @@ BUILD_JOBS=${BUILD_JOBS:-8} hostname +module purge No, this must be in machine specific files. If you do module purge on gaea, for example, the whole system falls apart. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#606 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TPYAY5QFJXF34HEMITTQ2EAJANCNFSM45U36N4Q> .

[DeniseWorthen]

Several nml.IN files are present in tests/parm but these have been removed from develop. I think they need to be removed.

[SMoorthi-emc]

Well, I guess the merge does not work right. I wonder why these files did not get removed when I merged (may be because in my version I had updated to remove 'ncld") This is one of the drawbacks of these fast commits I guess. I don't know which files need to be removed. Moorthi

…

On Mon, Jun 21, 2021 at 9:46 AM Denise Worthen ***@***.***> wrote: ***@***.**** requested changes on this pull request. Several nml.IN files are present in tests/parm but these have been removed from develop. I think they need to be removed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#606 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYRMOKLDJXSGDF577S3TT47CPANCNFSM45U36N4Q> .

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[DeniseWorthen]

This is the list of nml.IN currently in develop, tests/parm :

c96_HAFS_v0_hwrf.nml.IN
control_ca.nml.IN
control_csawmg.nml.IN
control_flake.nml.IN
control_gdas.nml.IN
control.nml.IN
control_noahmp.nml.IN
control_rrtmgp.nml.IN
control_thompson.nml.IN
control_ugwpv1.nml.IN
cpt.nml.IN
csawmg3shoc127.nml.IN
csawmgshoc.nml.IN
esg_HAFS_v0_hwrf.nml.IN
gsd.nml.IN
gsd_rrtmgp.nml.IN
gsd_sar.nml.IN
input.benchmark_v16.nml.IN
input.mom6_ccpp.nml.IN
input.mom6.nml.IN
input_nest02.nml.IN
multi_gases.nml.IN
regional_c768.nml.IN
regional.nml.IN
regional_rrtmgp.nml.IN
stretched-input.nml.IN
stretched-nest-input.nml.IN

[junwang-noaa]

Moorthi, your branch has different CDEPS and WW3 revisions:

8d9b9ecfdcb790bc19a58a9611a27bd43c9ebd2d CDEPS-interface/CDEPS (cdeps0.4.4-3-g8d9b9ec)
3740ba99caaa2822b5098bf32faeaf199a710a51 WW3 (6.07.1-97-g3740ba9)

while ufs-weather-model develop branch has:

07ca4a33eb47be20629fdf30e72f2eaf690a5110 CDEPS-interface/CDEPS (cdeps0.4.2-24-g07ca4a3)
097bbb65c4e372d52a733af911835a310cf54122 WW3 (6.07.1-88-g097bbb65)

Please point those two components to develop branch revisions. Thanks

[SMoorthi-emc]

Is cdep develop or EMC/ develop? I updated both cdep and ww3 last night. Moorthi

…

Sent from my iPhone

On Jun 22, 2021, at 4:31 PM, Jun Wang ***@***.***> wrote: Moorthi, your branch has different CDEPS and WW3 revisions: 8d9b9ecfdcb790bc19a58a9611a27bd43c9ebd2d CDEPS-interface/CDEPS (cdeps0.4.4-3-g8d9b9ec) 3740ba99caaa2822b5098bf32faeaf199a710a51 WW3 (6.07.1-97-g3740ba9) while ufs-weather-model develop branch has: 07ca4a33eb47be20629fdf30e72f2eaf690a5110 CDEPS-interface/CDEPS (cdeps0.4.2-24-g07ca4a3) 097bbb65c4e372d52a733af911835a310cf54122 WW3 (6.07.1-88-g097bbb65) Please point those two components to develop branch revisions. Thanks — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[junwang-noaa]

CDEPS is using the develop branch, the branch has a recent update, Bin Li has a ufs-weather-model PR to update UFS to use that version. Without the changes from that PR (or PR#611), the cdeps datm test can't get compiled. On Tue, Jun 22, 2021 at 4:37 PM SMoorthi-emc ***@***.***> wrote:

…

Is cdep develop or EMC/ develop? I updated both cdep and ww3 last night. Moorthi Sent from my iPhone > On Jun 22, 2021, at 4:31 PM, Jun Wang ***@***.***> wrote: > > Moorthi, your branch has different CDEPS and WW3 revisions: > > 8d9b9ecfdcb790bc19a58a9611a27bd43c9ebd2d CDEPS-interface/CDEPS (cdeps0.4.4-3-g8d9b9ec) > 3740ba99caaa2822b5098bf32faeaf199a710a51 WW3 (6.07.1-97-g3740ba9) > > while ufs-weather-model develop branch has: > > 07ca4a33eb47be20629fdf30e72f2eaf690a5110 CDEPS-interface/CDEPS (cdeps0.4.2-24-g07ca4a3) > 097bbb65c4e372d52a733af911835a310cf54122 WW3 (6.07.1-88-g097bbb65) > > Please point those two components to develop branch revisions. Thanks > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#606 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TPKGDIBTADUTP34UDDTUDYBPANCNFSM45U36N4Q> .

[SMoorthi-emc]

CDEp/develop is at "8d9b9ecfdcb790bc19a58a9611a27bd43c9ebd2d" Moorthi

…

On Tue, Jun 22, 2021 at 5:08 PM Jun Wang ***@***.***> wrote: CDEPS is using the develop branch, the branch has a recent update, Bin Li has a ufs-weather-model PR to update UFS to use that version. Without the changes from that PR (or PR#611), the cdeps datm test can't get compiled. On Tue, Jun 22, 2021 at 4:37 PM SMoorthi-emc ***@***.***> wrote: > Is cdep develop or EMC/ develop? > I updated both cdep and ww3 last night. > Moorthi > > Sent from my iPhone > > > On Jun 22, 2021, at 4:31 PM, Jun Wang ***@***.***> wrote: > > > > Moorthi, your branch has different CDEPS and WW3 revisions: > > > > 8d9b9ecfdcb790bc19a58a9611a27bd43c9ebd2d CDEPS-interface/CDEPS > (cdeps0.4.4-3-g8d9b9ec) > > 3740ba99caaa2822b5098bf32faeaf199a710a51 WW3 (6.07.1-97-g3740ba9) > > > > while ufs-weather-model develop branch has: > > > > 07ca4a33eb47be20629fdf30e72f2eaf690a5110 CDEPS-interface/CDEPS > (cdeps0.4.2-24-g07ca4a3) > > 097bbb65c4e372d52a733af911835a310cf54122 WW3 (6.07.1-88-g097bbb65) > > > > Please point those two components to develop branch revisions. Thanks > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub, or unsubscribe. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > < #606 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AI7D6TPKGDIBTADUTP34UDDTUDYBPANCNFSM45U36N4Q > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#606 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYXHJVTZUMV4GKBAGD3TUD3VDANCNFSM45U36N4Q> .

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[junwang-noaa]

Yes, that is the latest CDEPS develop revision, you need additional cmake updates in ufs in order to use that version. Currently the CDEPS DATM tests in your branch failed at compilation because of that. Please point to the CDEPS/develop revision 07ca4a3 <https://github.com/NOAA-EMC/CDEPS/tree/07ca4a33eb47be20629fdf30e72f2eaf690a5110> that ufs develop branch currently uses On Tue, Jun 22, 2021 at 7:34 PM SMoorthi-emc ***@***.***> wrote:

…

CDEp/develop is at "8d9b9ecfdcb790bc19a58a9611a27bd43c9ebd2d" Moorthi On Tue, Jun 22, 2021 at 5:08 PM Jun Wang ***@***.***> wrote: > CDEPS is using the develop branch, the branch has a recent update, Bin Li > has a ufs-weather-model PR to update UFS to use that version. Without the > changes from that PR (or PR#611), the cdeps datm test can't get compiled. > > On Tue, Jun 22, 2021 at 4:37 PM SMoorthi-emc ***@***.***> > wrote: > > > Is cdep develop or EMC/ develop? > > I updated both cdep and ww3 last night. > > Moorthi > > > > Sent from my iPhone > > > > > On Jun 22, 2021, at 4:31 PM, Jun Wang ***@***.***> wrote: > > > > > > Moorthi, your branch has different CDEPS and WW3 revisions: > > > > > > 8d9b9ecfdcb790bc19a58a9611a27bd43c9ebd2d CDEPS-interface/CDEPS > > (cdeps0.4.4-3-g8d9b9ec) > > > 3740ba99caaa2822b5098bf32faeaf199a710a51 WW3 (6.07.1-97-g3740ba9) > > > > > > while ufs-weather-model develop branch has: > > > > > > 07ca4a33eb47be20629fdf30e72f2eaf690a5110 CDEPS-interface/CDEPS > > (cdeps0.4.2-24-g07ca4a3) > > > 097bbb65c4e372d52a733af911835a310cf54122 WW3 (6.07.1-88-g097bbb65) > > > > > > Please point those two components to develop branch revisions. Thanks > > > > > > — > > > You are receiving this because you authored the thread. > > > Reply to this email directly, view it on GitHub, or unsubscribe. > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub > > < > #606 (comment) > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AI7D6TPKGDIBTADUTP34UDDTUDYBPANCNFSM45U36N4Q > > > > . > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > < #606 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ALLVRYXHJVTZUMV4GKBAGD3TUD3VDANCNFSM45U36N4Q > > . > -- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#606 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TPNSP5TNWJL5YNU4ELTUEMXXANCNFSM45U36N4Q> .

[SMoorthi-emc]

Well, I can't get the stochastic test working; it appears that allocated arrays are reallocated again. Moorthi

…

On Tue, Jun 22, 2021 at 9:46 PM Jun Wang ***@***.***> wrote: Yes, that is the latest CDEPS develop revision, you need additional cmake updates in ufs in order to use that version. Currently the CDEPS DATM tests in your branch failed at compilation because of that. Please point to the CDEPS/develop revision 07ca4a3 < https://github.com/NOAA-EMC/CDEPS/tree/07ca4a33eb47be20629fdf30e72f2eaf690a5110 > that ufs develop branch currently uses On Tue, Jun 22, 2021 at 7:34 PM SMoorthi-emc ***@***.***> wrote: > CDEp/develop is at > "8d9b9ecfdcb790bc19a58a9611a27bd43c9ebd2d" > Moorthi > > On Tue, Jun 22, 2021 at 5:08 PM Jun Wang ***@***.***> wrote: > > > CDEPS is using the develop branch, the branch has a recent update, Bin Li > > has a ufs-weather-model PR to update UFS to use that version. Without the > > changes from that PR (or PR#611), the cdeps datm test can't get compiled. > > > > On Tue, Jun 22, 2021 at 4:37 PM SMoorthi-emc ***@***.***> > > wrote: > > > > > Is cdep develop or EMC/ develop? > > > I updated both cdep and ww3 last night. > > > Moorthi > > > > > > Sent from my iPhone > > > > > > > On Jun 22, 2021, at 4:31 PM, Jun Wang ***@***.***> wrote: > > > > > > > > Moorthi, your branch has different CDEPS and WW3 revisions: > > > > > > > > 8d9b9ecfdcb790bc19a58a9611a27bd43c9ebd2d CDEPS-interface/CDEPS > > > (cdeps0.4.4-3-g8d9b9ec) > > > > 3740ba99caaa2822b5098bf32faeaf199a710a51 WW3 (6.07.1-97-g3740ba9) > > > > > > > > while ufs-weather-model develop branch has: > > > > > > > > 07ca4a33eb47be20629fdf30e72f2eaf690a5110 CDEPS-interface/CDEPS > > > (cdeps0.4.2-24-g07ca4a3) > > > > 097bbb65c4e372d52a733af911835a310cf54122 WW3 (6.07.1-88-g097bbb65) > > > > > > > > Please point those two components to develop branch revisions. Thanks > > > > > > > > — > > > > You are receiving this because you authored the thread. > > > > Reply to this email directly, view it on GitHub, or unsubscribe. > > > > > > — > > > You are receiving this because you commented. > > > Reply to this email directly, view it on GitHub > > > < > > > #606 (comment) > > >, > > > or unsubscribe > > > < > > > https://github.com/notifications/unsubscribe-auth/AI7D6TPKGDIBTADUTP34UDDTUDYBPANCNFSM45U36N4Q > > > > > > . > > > > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > < > #606 (comment) > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/ALLVRYXHJVTZUMV4GKBAGD3TUD3VDANCNFSM45U36N4Q > > > > . > > > > > -- > Dr. Shrinivas Moorthi > Research Meteorologist > Modeling and Data Assimilation Branch > Environmental Modeling Center / National Centers for Environmental > Prediction > 5830 University Research Court - (W/NP23), College Park MD 20740 USA > Tel: (301)683-3718 > > e-mail: ***@***.*** > Phone: (301) 683-3718 Fax: (301) 683-3718 > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > < #606 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AI7D6TPNSP5TNWJL5YNU4ELTUEMXXANCNFSM45U36N4Q > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#606 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYUO2Y7RMWQRZUDVP3DTUE4HRANCNFSM45U36N4Q> .

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718