Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to C3 and SAS convection schemes #1965

Closed
wants to merge 11 commits into from

Conversation

lisa-bengtsson
Copy link
Contributor

@lisa-bengtsson lisa-bengtsson commented Oct 25, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG: /scratch2/BMC/gsienkf/Lisa.Bengtsson/RegressionTests_hera.log
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

*Brings out tuning parameters from the progsigma_calc.F90, which are used in the saSAS and C3 shallow and deep cumulus convection schemes.
*Adds a limiter on area fraction to not exceed 0.95 after final tuning
*Updates the regression test namelist used for gfsv17 (HR3) tests, to include extracted parameters in the namelist.

For RRFSv1 ensemble members using saSAS convection, workflow updates are needed.

Some justification for the PR can be found here: https://docs.google.com/presentation/d/11WVCFAb-JM628N2RyAWLqjxxrSovKU8AB72xBZJ1FfI/edit#slide=id.p

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Closes #1964

Subcomponent Pull Requests

ufs-community/ccpp-physics#122
NOAA-EMC/fv3atm#715

Blocking Dependencies

None

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@lisa-bengtsson
Copy link
Contributor Author

lisa-bengtsson commented Oct 26, 2023

All RT's pass on Hera:
/scratch2/BMC/gsienkf/Lisa.Bengtsson/RegressionTests_hera.log
No changes to baselines.

@BrianCurtis-NOAA BrianCurtis-NOAA added No Baseline Change No Baseline Change Incomplete This PR does not have all required information. Please see PR Author checklist. labels Nov 9, 2023
@BrianCurtis-NOAA
Copy link
Collaborator

Incomplete is just waiting on PR review in FV3atm

@lisa-bengtsson
Copy link
Contributor Author

@BrianCurtis-NOAA @SamuelTrahanNOAA my understanding is that we will close this PR and the corresponding FV3 PR as it's been merged with Sam's PR on the global nest. Sam can you confirm that I can close these?

@BrianCurtis-NOAA
Copy link
Collaborator

OK that's fine. If you add closes #1965 to Sam's PR it should close this PR once his is merged. No need to do anything here except keeping the note it's a part of his. Thanks!

@BrianCurtis-NOAA BrianCurtis-NOAA added Waiting for Reviews The PR is waiting for reviews from associated component PR's. and removed Incomplete This PR does not have all required information. Please see PR Author checklist. labels Nov 13, 2023
FernandoAndrade-NOAA pushed a commit that referenced this pull request Nov 15, 2023
* update FD and nems.configure

* add new suite_FV3_global_nest_v1 to FV3

* new tests for global_nest_v1 suite

* update tests to match new gwd scheme

* Namelist changes from Mike Toy & adapt to changes from develop in FV3

* Merge FV3 NOAA-EMC/fv3atm#715 from @lisa-bengtsson

* remove unused tests/rap_clm_lake

* Update bl_date.conf

* note that gnv1_nested might work on s4

* Update cpld_control_p8 remove hera_gnu wall clock stipulation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to C3 and SAS cumulus convection schemes
2 participants