Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for RRFS 32-bit physics support, and minor feature additions #1797

Merged
merged 84 commits into from
Jul 10, 2023
Merged
Show file tree
Hide file tree
Changes from 82 commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
92b9e2a
refactor FV3GFS restart, add clm lake and rrfs-sd to quilt restart
SamuelTrahanNOAA May 23, 2023
a2f0e54
point to refactor-restart
SamuelTrahanNOAA May 23, 2023
1ee7bf1
update FV3
SamuelTrahanNOAA May 23, 2023
54359f6
rrfs sd restart in quilt (still under testing)
SamuelTrahanNOAA May 24, 2023
da45bcd
Merge remote-tracking branch 'origin/develop' into c17-sd
SamuelTrahanNOAA May 24, 2023
fc1ba65
explicitly write axis values (from DusanJovic-NOAA), and clean up code
SamuelTrahanNOAA May 24, 2023
5c9a9d6
intel tests passed
SamuelTrahanNOAA May 25, 2023
3d66b42
hera.gnu tests passed
SamuelTrahanNOAA May 25, 2023
8ee7416
Merge branch 'c17-sd' into refactor-restart
SamuelTrahanNOAA May 25, 2023
c0653d9
rename FV3GFS to fv3atm in code, except output metadata
SamuelTrahanNOAA May 26, 2023
c19c57b
refactor a bit more, putting history into fv3atm_history_io.F90 and r…
SamuelTrahanNOAA May 29, 2023
f6ea1b1
hera gnu tests passed
SamuelTrahanNOAA May 29, 2023
1398315
hera.intel tests passed
SamuelTrahanNOAA May 29, 2023
3d6e489
Merge branch 'refactor-restart' of ssh://github.com/SamuelTrahanNOAA/…
SamuelTrahanNOAA May 29, 2023
9f1ec7a
more cleanup in FV3
SamuelTrahanNOAA May 30, 2023
4a79081
Merge branch 'refactor-restart' of ssh://github.com/SamuelTrahanNOAA/…
SamuelTrahanNOAA May 30, 2023
2579095
delete trailing whitespace in new FV3/io files
SamuelTrahanNOAA May 30, 2023
30493fa
hera.intel passed after revision c26-ruc-lsm
SamuelTrahanNOAA May 30, 2023
dc943f3
hera.gnu tests passed again
SamuelTrahanNOAA May 30, 2023
93dd911
add the two qr hurr_control tests
SamuelTrahanNOAA May 31, 2023
24e0ac8
update fv3atm hash
SamuelTrahanNOAA May 31, 2023
f26f271
revert accidental change to rt.sh
SamuelTrahanNOAA May 31, 2023
5efd8f8
merge upstream develop
SamuelTrahanNOAA May 31, 2023
d7f442b
hera.intel passed again
SamuelTrahanNOAA May 31, 2023
153164f
hera.gnu passed again
SamuelTrahanNOAA May 31, 2023
5f69611
Merge branch 'refactor-restart' of ssh://github.com/SamuelTrahanNOAA/…
SamuelTrahanNOAA May 31, 2023
a4da88a
comments, consistent indentation, remove trailing whitespace
SamuelTrahanNOAA May 31, 2023
b6adc86
Even longer explanation of RUC LSM axes from @tanyasmirnova
SamuelTrahanNOAA May 31, 2023
1e63fc0
Merge branch 'refactor-restart' of ssh://github.com/SamuelTrahanNOAA/…
SamuelTrahanNOAA May 31, 2023
22c5b25
missing dependency for rrfs_smoke_conus13km_hrrr_warm_restart
SamuelTrahanNOAA Jun 2, 2023
8c43209
merge upstream develop
SamuelTrahanNOAA Jun 2, 2023
bcc6760
do not delete tests/lock directory when another rt.sh is running
SamuelTrahanNOAA Jun 2, 2023
d562adf
mismatch_qr => qr_mismatch
SamuelTrahanNOAA Jun 2, 2023
f15ec21
Set THRD variable in rrfs 2threads tests
SamuelTrahanNOAA Jun 2, 2023
5ac21a3
corrections to rt.conf
SamuelTrahanNOAA Jun 4, 2023
28a7b61
bug fix to "alt check" code: add -S -q to avoid infinite output
SamuelTrahanNOAA Jun 4, 2023
036a6c1
32-bit quilt restart tests
SamuelTrahanNOAA Jun 4, 2023
4438550
hera tests passed
SamuelTrahanNOAA Jun 4, 2023
feffad0
use process id instead of $delete_lock to decide3 whether to delete t…
SamuelTrahanNOAA Jun 5, 2023
bf837fb
Remove THRD= from smoke tests
SamuelTrahanNOAA Jun 6, 2023
698aad1
no THRD in non-smoke conus13km tests
SamuelTrahanNOAA Jun 6, 2023
ad77a6a
hera tests passed again
SamuelTrahanNOAA Jun 6, 2023
47de6a9
bug fixes for RRFS 32-bit physics
SamuelTrahanNOAA Jun 14, 2023
3809b90
errors in new tests
SamuelTrahanNOAA Jun 15, 2023
e9b7425
do not enforce counter=nr, but require monotonic. Note to self: remov…
SamuelTrahanNOAA Jun 15, 2023
fd18b8e
merge upstream develop
SamuelTrahanNOAA Jun 15, 2023
4d93c63
incorrect dependency
SamuelTrahanNOAA Jun 15, 2023
fe9ca45
bug fixes for 32-bit physics support
SamuelTrahanNOAA Jun 15, 2023
3752922
name the compilation lines instead of numbering them
SamuelTrahanNOAA Jun 16, 2023
6c6c393
p8_pdlib => p8_s2sw_pdlib
SamuelTrahanNOAA Jun 16, 2023
72b6fa3
p8_faster => p8_s2sw_faster
SamuelTrahanNOAA Jun 16, 2023
6b0802d
p8_s2s_cmeps => p8_s2s_aoflux and p8_ng_godas => datm_cdeps
SamuelTrahanNOAA Jun 16, 2023
f9f70e0
p8_s2sw_faster => p8_s2swa_faster
SamuelTrahanNOAA Jun 16, 2023
ec1dc75
use app as compilation name, usually
SamuelTrahanNOAA Jun 16, 2023
c223ad7
missing quilting_restart: line from parm/model_configure_rrfs_conus13…
SamuelTrahanNOAA Jun 20, 2023
d65a3dc
merge upstream develop to FV3
SamuelTrahanNOAA Jun 20, 2023
0879891
merge upstream develop
SamuelTrahanNOAA Jun 20, 2023
986e6cc
Not all arguments were being passed to run/compile environments
BrianCurtis-NOAA Jun 27, 2023
7d44c2f
merge upstream develop
SamuelTrahanNOAA Jun 29, 2023
bdd8dca
corrections to merge of rt.conf
SamuelTrahanNOAA Jun 29, 2023
404a2f1
Merge branch 'ufs-community:develop' into fixortdbg
BrianCurtis-NOAA Jun 29, 2023
9a00ddd
revert accidental change to rt.sh
SamuelTrahanNOAA Jun 30, 2023
86212e1
hera test logs
SamuelTrahanNOAA Jun 30, 2023
d897ce4
update "item 2" documentation
SamuelTrahanNOAA Jul 5, 2023
475528b
merge upstream develop
SamuelTrahanNOAA Jul 5, 2023
f440e52
Merge branch 'ufs-community:develop' into fixortdbg
BrianCurtis-NOAA Jul 5, 2023
4f3a555
hera tests passed again
SamuelTrahanNOAA Jul 5, 2023
d737fa6
Fixes for WCOSS2/Acorn UNBOUND VARIABLE error
BrianCurtis-NOAA Jul 6, 2023
d110a26
merge upstream
SamuelTrahanNOAA Jul 7, 2023
46cbb73
merge #1810
SamuelTrahanNOAA Jul 7, 2023
e3b4341
bug fix for rt.sh -m
SamuelTrahanNOAA Jul 7, 2023
c72f93f
hera tests passed again
SamuelTrahanNOAA Jul 7, 2023
86078c5
Add new BL_DATE
jkbk2004 Jul 7, 2023
424d39f
revert change: bl_date.conf
jkbk2004 Jul 7, 2023
aa18822
comment out invalid gaea qos
jkbk2004 Jul 9, 2023
6512722
add machine option lines in rt.conf: gnu rrfs
jkbk2004 Jul 9, 2023
6ec509e
add gaea RT log: passed
jkbk2004 Jul 9, 2023
5ebc774
add jet RT log: passed
jkbk2004 Jul 9, 2023
b183d65
add hera RT logs: passed
zach1221 Jul 10, 2023
64883bd
add orion RT logs: passed
zach1221 Jul 10, 2023
c48e452
-a check was in the wrong place
SamuelTrahanNOAA Jul 10, 2023
3c05abc
remove unused test
SamuelTrahanNOAA Jul 10, 2023
23b5af4
Acorn RT Log
BrianCurtis-NOAA Jul 10, 2023
08a9d09
point to develop branch of fv3atm
SamuelTrahanNOAA Jul 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
url = https://github.com/SamuelTrahanNOAA/fv3atm
branch = refactor-restart
[submodule "WW3"]
path = WW3
url = https://github.com/NOAA-EMC/WW3
Expand Down
2 changes: 1 addition & 1 deletion FV3
2 changes: 1 addition & 1 deletion tests/fv3_conf/fv3_slurm.IN_gaea
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#SBATCH -o out
#SBATCH --job-name="@[JBNME]"
#SBATCH --account=@[ACCNR]
#SBATCH --qos=@[QUEUE]
##SBATCH --qos=@[QUEUE]
#SBATCH --clusters=@[PARTITION]
#SBATCH --nodes=@[NODES]
#SBATCH --ntasks-per-node=@[TPN]
Expand Down
1,746 changes: 926 additions & 820 deletions tests/logs/RegressionTests_gaea.log

Large diffs are not rendered by default.

2,391 changes: 1,301 additions & 1,090 deletions tests/logs/RegressionTests_hera.log

Large diffs are not rendered by default.

1,400 changes: 751 additions & 649 deletions tests/logs/RegressionTests_jet.log

Large diffs are not rendered by default.

8,886 changes: 5,448 additions & 3,438 deletions tests/logs/RegressionTests_orion.log

Large diffs are not rendered by default.

18 changes: 5 additions & 13 deletions tests/opnReqTest
Original file line number Diff line number Diff line change
Expand Up @@ -137,16 +137,13 @@ build_opnReqTests() {
run_opnReqTests() {
JOB_NR=0
for rc in $run_case; do
# load default variables and override as necessary
source default_vars.sh
source ${PATHRT}/tests/$TEST_NAME

# if TEST_NAME specifies WARM_START true, error and exit
source ${PATHRT}/tests/$TEST_NAME
if [[ ${WARM_START} == .T. ]]; then
error "test-name cannot be a restart run (i.e. WARM_START=.T.)"
fi

application=''
if [[ $TEST_NAME =~ regional ]]; then
application=regional
elif [[ $TEST_NAME =~ cpld ]]; then
Expand Down Expand Up @@ -251,6 +248,7 @@ run_opnReqTests() {
export skip_check_results=${skip_check_results}
export delete_rundir=${delete_rundir}
export RT_COMPILER=${RT_COMPILER}
export WLCLK=${WLCLK}
EOF

if [[ $ECFLOW == true ]]; then
Expand Down Expand Up @@ -345,8 +343,6 @@ if [[ $MACHINE_ID = hera ]]; then
STMP=${dprefix}/stmp4
PTMP=${dprefix}/stmp2
SCHEDULER=slurm
cp fv3_conf/fv3_slurm.IN_hera fv3_conf/fv3_slurm.IN
cp fv3_conf/compile_slurm.IN_hera fv3_conf/compile_slurm.IN

elif [[ $MACHINE_ID = orion ]]; then

Expand All @@ -364,8 +360,6 @@ elif [[ $MACHINE_ID = orion ]]; then
STMP=$dprefix/stmp
PTMP=$dprefix/stmp
SCHEDULER=slurm
cp fv3_conf/fv3_slurm.IN_orion fv3_conf/fv3_slurm.IN
cp fv3_conf/compile_slurm.IN_orion fv3_conf/compile_slurm.IN

elif [[ $MACHINE_ID = linux ]]; then

Expand Down Expand Up @@ -468,6 +462,9 @@ if [[ $dbg_compare == true && ! $test_case =~ dbg ]]; then
error "$program: debug reproducibility test requires specifying dbg"
fi

# load default variables and override as necessary
source default_vars.sh

# enumerate which case to compile and run
compile_case=
run_case=
Expand Down Expand Up @@ -547,11 +544,6 @@ if [[ $ECFLOW == true ]]; then
error "ecflow is not supported on this machine $MACHINE_ID"
fi

if [[ $MACHINE_ID == hera ]] && [[ ! $HOSTNAME == hecflow* ]]; then
echo "ERROR: To use ECFlow on Hera please use the 'hecflow01' login node: ssh hecflow01."
exit 1
fi

fi

opnreqtest_log=${PATHRT}/logs/OpnReqTests_${TEST_NAME}_$MACHINE_ID.log
Expand Down
1 change: 1 addition & 0 deletions tests/parm/model_configure_rrfs_conus13km.IN
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ restart_interval: @[RESTART_INTERVAL]
output_1st_tstep_rst: .false.

quilting: @[QUILTING]
quilting_restart: @[QUILTING_RESTART]
write_groups: @[WRITE_GROUP]
write_tasks_per_group: @[WRTTASK_PER_GROUP]
output_history: @[OUTPUT_HISTORY]
Expand Down
123 changes: 67 additions & 56 deletions tests/rt.conf

Large diffs are not rendered by default.

Loading