Bugfixes for RRTMGP

[dustinswales]

Description

Top of commit queue on: TBD

Input data additions/changes

• No changes are expected to input data.
• There will be new input data.
• Input data will be updated.

Anticipated changes to regression tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Combined with PR's (If Applicable):

Commit Queue Checklist:

• Link PR's from all sub-components involved
• Confirm reviews completed in sub-component PR's
• Add all appropriate labels to this PR.
• Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
• Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

NOAA-EMC #655
Fix to allow for threading in RRTMGP #70
Addresses UWM:ccpp-physics Issue #59

Testing Day Checklist:

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

• RDHPCS
  • Intel
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • GNU
    • Hera
    • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[FernandoAndrade-NOAA]

Hi @dustinswales, could you sync with develop, link the FV3 sub PR, and provide any Hera intel/gnu or Cheyenne intel/gnu logs?

[dustinswales]

Hi @dustinswales, could you sync with develop, link the FV3 sub PR, and provide any Hera intel/gnu or Cheyenne intel/gnu logs?

Done. (No logs, I wiped them when updating, but tested on Cheyenne Intel)

[FernandoAndrade-NOAA]

@dustinswales, #1743 was merged in, could you resync with develop and resolve conflicts? We can get started with jenkins-ci and ORTs following that.

[FernandoAndrade-NOAA]

Hi @dustinswales, just checking in if you're ready to sync and resolve conflicts in order to proceed with testing this PR

[dustinswales]

@FernandoAndrade-NOAA sorry for the delay. I will sync in the coming hour

[jkbk2004]

Looks like all code changes only for check error messages. No baseline change and all tests pass on cheyenne. @dustinswales can we confirm?

[DeniseWorthen]

@jkbk2004 Were the RTs ever run for this PR? It seems that you are finding no change in baseline, but there was an expected change (in the PR description) that the control_p8_rrtmgp test would change. We don't know if it should or not because the pre-commit logs don't seem to have been posted.

[jkbk2004]

Yeah, we need @dustinswales to confirm.

[dustinswales]

@jkbk2004 @DeniseWorthen
The RTs haven’t been run yet. I synced last week, and again last night. I thought that @FernandoAndrade-NOAA was initiating the testing?
(I’m not sure where that Cheyenne log came from in ea795b7)

[DeniseWorthen]

@dustinswales Thanks....I think my confusion is that you listed in the description that the baseline would change for control_p8_rrtmgp. Do you know for sure that is expected?

[dustinswales]

@DeniseWorthen Yes, the control_p8_rrtmgp should need new baselines, but now I'm nervous and rechecking on Cheyenne.

[dustinswales]

@DeniseWorthen @jkbk2004 I looks like I was mistaken. I just reran on Cheyenne and the baselines didn't change for the RRTMGP test, /glade/work/dswales/UFS/RRTMGP/ufs-weather-model/tests/logs/RegressionTests_cheyenne.log.

[FernandoAndrade-NOAA]

Attached are the jenkins ci logs from earlier, ORTs passed. @dustinswales I'd like to double check with you whether there are any baseline changes expected, including the control_p8_rrtmgp? Just making sure before I start up the full RTs. Thank you.
ufs-weather-model » ort-docker-pipeline » PR-1751 #1 Console [Jenkins].pdf

[jkbk2004]

@BrianCurtis-NOAA FYI: on-going this pr with no baseline change

[dustinswales]

Attached are the jenkins ci logs from earlier, ORTs passed. @dustinswales I'd like to double check with you whether there are any baseline changes expected, including the control_p8_rrtmgp? Just making sure before I start up the full RTs. Thank you. ufs-weather-model » ort-docker-pipeline » PR-1751 #1 Console [Jenkins].pdf

@FernandoAndrade-NOAA Correct. No baseline changes.

[FernandoAndrade-NOAA]

Sub FV3 PR #655 has been merged in. Please go ahead and update hash and gitmodules