Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update WW3 with its develop branch #1625

Merged
merged 15 commits into from
Mar 13, 2023

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Feb 24, 2023

Description

Belated routine update of WW3 to merge in updates from develop to the dev/ufs-weather-model branch of WW3 in ufs-weather-model.
This PR now brings in the ability to use the SCOTCH domain decomposition library (alternative to ParMETIS). This PR will not take advantage of this feature on the ufs-weather-model level, but it is included in the WW3 update.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

(This PR could be combined with any other PR that does not involve WW3. This should not be combined with other PRs that update WW3).

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BrianCurtis-NOAA BrianCurtis-NOAA added the No Baseline Change No Baseline Change label Feb 24, 2023
@BrianCurtis-NOAA
Copy link
Collaborator

Please attach the regression tests gnu and intel log showing no baselines change with this PR to a comment here.

Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No impactful changes to UFSWM, approved for testing once it's in commit queue.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@JessicaMeixner-NOAA
Copy link
Collaborator Author

I pushed 2 recent updates to the WW3 develop branch to this sync. This will fix the CI (again) and merges in the update which includes the ability to use SCOTCH instead of ParMETIS (not actually turned on). I also merged the latest ufs-weather-model and re-ran tests:
RegressionTests_hera.gnu.log
RegressionTests_hera.intel.log
There are still no answer changes in this PR.

@BrianCurtis-NOAA BrianCurtis-NOAA added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

@JessicaMeixner-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • cmake NOT up to date

@zach1221
Copy link
Collaborator

zach1221 commented Mar 9, 2023

Hi, @JessicaMeixner-NOAA we're going to start working through this PR next and begin testing.

@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Mar 9, 2023
@zach1221
Copy link
Collaborator

Please see jenkins-ci logs attached. ORTs have passed.
ufs-weather-model » ort-docker-pipeline » PR-1625 #1 Console [Jenkins].pdf

@zach1221 zach1221 added hera-intel-RT and removed jenkins-ci Jenkins CI: ORT build/test on docker container labels Mar 10, 2023
@jkbk2004
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: RT
[RT] Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/1253252250/20230310134519/ufs-weather-model
[RT] Error: Test cpld_control_p8 046 failed in run_test failed
Please make changes and add the following label back: hera-gnu-RT

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@jkbk2004 @zach1221 It looks like all the regression tests have passed, are we ready for the WW3 PR to be merged?

@jkbk2004
Copy link
Collaborator

@JessicaMeixner-NOAA @zach1221 Sure! go ahead to merge in the WW3 dependency.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

WW3 PR has been merged and committed to this PR.

@jkbk2004 jkbk2004 self-requested a review March 13, 2023 13:10
@jkbk2004 jkbk2004 merged commit daa7a5d into ufs-community:develop Mar 13, 2023
@support-epic
Copy link
Collaborator

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
[RT] Repo location: /mnt/lfs4/HFIP/hfv3gfs/role.epic/autort/pr/1253252250/20230310140711/ufs-weather-model
Please make changes and add the following label back: jet-intel-RT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update WW3 with its develop branch
6 participants