Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use esmf-managed threading for cpld_bmark control and restart #1483

Closed

Conversation

DeniseWorthen
Copy link
Collaborator

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Replaces the cpld_bmark_p8 test with the cpld_bmark_esmfthreads_p8 test. Add esmf-managed threading to bmark restart test.

Issue(s) addressed

-fixes issue #1479

Testing

The cpld_bmark_p8 and cpld_restart_bmark_p8 were run on hera.intel at 807c628 and both passed. The nems.configure in the control and restart runs were compared and were identical except for the runtype setting.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

None. Script level changes only.

DeniseWorthen and others added 3 commits November 8, 2022 09:27
* bmark cpld tests use esmf-managed threading by default
* remove version w/o esmf-managed threading
* feature is now in cpld_bmark by default
@DeniseWorthen DeniseWorthen added the No Baseline Change No Baseline Change label Nov 8, 2022
@DeniseWorthen
Copy link
Collaborator Author

Combined with #1486; closing.

jkbk2004 added a commit that referenced this pull request Nov 16, 2022
…reading for cpld_bmark control and restart (was #1483); Software module updates in hpc-stack for Hera (intel, gnu) (was #1468) (#1486)

* update CMEPS submodule

* bmark cpld tests use esmf-managed threading by default
* remove version w/o esmf-managed threading

* update hera hpc stack locations: intel/gnu

Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
Co-authored-by: zach1221 <[email protected]>
@DeniseWorthen DeniseWorthen deleted the feature/default_emt branch November 21, 2022 19:46
@DeniseWorthen DeniseWorthen self-assigned this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant