Switch to "atparse" instead of "edit_inputs" for ice_in and MOM_input templates #783
Assignees
Labels
enhancement
New feature or request
Comments
14 tasks
13 tasks
epic-cicd-jenkins
pushed a commit
that referenced
this issue
Apr 17, 2023
## DESCRIPTION OF CHANGES: PR #[763](ufs-community/regional_workflow#763) introduced the experiment variable `POST_OUTPUT_DOMAIN_NAME` and used it to modify the names of the UPP output files. This PR adds `POST_OUTPUT_DOMAIN_NAME` as an argument to the python plotting scripts to enable those scripts to form the proper UPP output file names to read in. It also modifies the batch scripts (`qsub_job.sh`, `qsub_job_diff.sh`, `sq_job.sh`, and `sq_job_diff.sh`) to add the new argument to the calls to the python plotting scripts that are called. ## TESTS CONDUCTED: Both python plotting scripts `plot_allvars.py` and `plot_allvars_diff.py` were run on Hera on preexisting UPP output files and completed successfully. The batch scripts `sq_job.sh` and `sq_job_diff.sh` were also run successfully on Hera (`qsub_job.sh` and `qsub_job_diff.sh` were not run on e.g. Cheyenne). ## DEPENDENCIES: PR # in `ufs-srweather-app`. ## DOCUMENTATION: Modifications to the documentation are in PR #. ## ISSUE: Partially resolves issue #781 (still need to introduce tests in `regional_workflow` that run the plotting scripts). ## CONTRIBUTORS: @mark-a-potts pointed out the problem and first made the necessary fixes in the `NOAA-EPIC` fork of `regional_workflow`; @gsketefian introduced those changes to this PR and made edits to the comments and documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The ice_in and MOM_input templates should be processed in the same manner as other input namelists rather than with the
sedcommand and theedit_inputsfunction.Solution
Switch required templates to use
@[configuration_setting]and add requiredatparsecommands inrun_test.shThe text was updated successfully, but these errors were encountered: