Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Return Jet to Jenkinsfile. #714

Conversation

MichaelLueken
Copy link
Collaborator

DESCRIPTION OF CHANGES:

Following the migration to a new site for Jenkins, communication between Jenkins and Hera/Jet have been lost. Guidance from this afternoon (April 5, 2023) says that communication should be returned by CoB today. So, I have gone ahead and reactivated Jet in the Jenkinsfile.

Please note, that until the nems account has been replaced with epic for Hera, Hera tests will remain off.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

Testing will need to wait until communication has been restored between Jenkins and Jet.

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes #713

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@MichaelLueken
Copy link
Collaborator Author

If communication with Jet returns within the next hour, I will go ahead and submit the Jenkins tests. Otherwise, please wait until confirmation that Jet is back before adding the run_we2e_fundamental_tests label to this PR. Thanks!

@MichaelLueken
Copy link
Collaborator Author

Communication has been restored! Submitting Jenkins tests now.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Apr 5, 2023
Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks!

Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MichaelLueken!

@MichaelLueken
Copy link
Collaborator Author

All Jenkins automated tests passed. Merging now.

@MichaelLueken MichaelLueken merged commit 6f96f19 into ufs-community:develop Apr 7, 2023
@MichaelLueken MichaelLueken deleted the feature/update_jenkinsfile branch April 7, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore Jet automated testing in Jenkinsfile
4 participants