Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Ensure arbitrary restart_interval numbers in model_configure #503

Merged
merged 2 commits into from
Dec 5, 2022
Merged

[develop] Ensure arbitrary restart_interval numbers in model_configure #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cbe139
ensure arbitrary restart_interval
Dec 1, 2022
6c22e75
remove wtime change in we2e
Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parm/model_configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ cpl: {{ cpl }}
calendar: 'julian'
memuse_verbose: .false.
atmos_nthreads: {{ atmos_nthreads }}
restart_interval: {{ restart_interval }} -1
restart_interval: {{ restart_interval }}
output_1st_tstep_rst: .false.
write_dopost: {{ write_dopost }}
ideflate: 0
Expand Down
8 changes: 4 additions & 4 deletions tests/WE2E/test_configs/wflow_features/config.specify_RESTART_INTERVAL.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ metadata:
description: |-
This test checks the capability of the workflow to have the time
interval (RESTART_INTERVAL) at which restart files are written by the
forecast model be set to a user-specified value.
forecast model be set to user-specified values.
user:
RUN_ENVIR: community
workflow:
CCPP_PHYS_SUITE: FV3_GFS_v15p2
CCPP_PHYS_SUITE: FV3_GFS_v16
PREDEF_GRID_NAME: RRFS_CONUS_25km
DATE_FIRST_CYCL: '2019070100'
DATE_LAST_CYCL: '2019070100'
Expand All @@ -17,7 +17,7 @@ task_get_extrn_ics:
USE_USER_STAGED_EXTRN_FILES: true
task_get_extrn_lbcs:
EXTRN_MDL_NAME_LBCS: FV3GFS
LBC_SPEC_INTVL_HRS: 3
LBC_SPEC_INTVL_HRS: 6
USE_USER_STAGED_EXTRN_FILES: true
task_run_fcst:
RESTART_INTERVAL: 1
RESTART_INTERVAL: 1 2 5
6 changes: 4 additions & 2 deletions ush/config_defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,8 +1490,10 @@ task_run_fcst:
# RESTART_INTERVAL:
# frequency of the output restart files (unit:hour).
# Default=0: restart files are produced at the end of a forecast run
# For example, RESTART_INTERVAL: 1: restart files are produced every hour
# with the prefix "YYYYMMDD.HHmmSS." in the RESTART directory
# For example, i) RESTART_INTERVAL: 1 -1 => restart files are produced
# every hour with the prefix "YYYYMMDD.HHmmSS." in the RESTART directory
# ii) RESTART_INTERVAL: 1 2 5 => restart files are produced only when
# fh = 1, 2, and 5.
#
# WRITE_DOPOST:
# Flag that determines whether or not to use the inline post feature
Expand Down
6 changes: 0 additions & 6 deletions ush/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,12 +569,6 @@ def get_location(xcs, fmt):
FCST_MODEL = '{FCST_MODEL}'"""
)

# Make sure RESTART_INTERVAL is set to an integer value
if not isinstance(RESTART_INTERVAL, int):
raise Exception(
f"\nRESTART_INTERVAL = {RESTART_INTERVAL}, must be an integer value\n"
)

# Check that input dates are in a date format

# get dictionary of all variables
Expand Down