Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing compile.sh and updating before_components.mk, configure.fv3.… #93

Closed
wants to merge 4 commits into from

Conversation

SMoorthi-emc
Copy link
Collaborator

…hera.intel, and configure.fv3.wcoss_dell_p3

With this version of compile.sh we can compile FV3, FV3+WW3, FV3+MOM6+CICE, and FV3+MOM6+CICE+WW3 (IPD or CCPP).
And you can remove many redundant configure and module files and the "s2s" and "weather" models can be unified.

@SMoorthi-emc
Copy link
Collaborator Author

To compile FV3+MOM6+CICE+WW3 with CCPP on hera would be from the tests directory
compile.sh ../FV3 hera.intel 'CCPP=Y SUITES=FV3_GFS_2017_coupled MOM6=Y CICE=Y WW3=Y' cpld YES NO >&compile.log&
One can do multiple suites in CCPP if one wishes.

@MinsukJi-NOAA
Copy link
Collaborator

Debug build requires choosing a different module file that uses esmf800g, which is currently done in before_components.mk. It seems that this part is deleted...

@SMoorthi-emc
Copy link
Collaborator Author

It was not deleted; it was never added in my version as I was not aware of it. But it should be easy to add I suppose.

@SMoorthi-emc
Copy link
Collaborator Author

Is there a debug version of "esmf/8.0.0_ParallelNetCDF"?

@SMoorthi-emc
Copy link
Collaborator Author

I also assume that there is no debug version on WCOSS Dell

@MinsukJi-NOAA
Copy link
Collaborator

On Hera, esmf/8.0.0 debug version is used.
On Orion, esmf/8.0.0.para debug version is used.
On WCOSS Dell, I am not sure.

@SMoorthi-emc
Copy link
Collaborator Author

I have updated before_components.mk

@MinsukJi-NOAA
Copy link
Collaborator

MinsukJi-NOAA commented May 28, 2020

I merged the latest s2s develop branch into Moorthi's branch and tested using rt.sh:

  1. All debug tests had run-time errors
  2. With the fv3 module, all RT's did not pass, although all runs were completed
  3. With the fv3_coupled module, all RT's (except debug) passed

I will add changes to address the above, and to modify rt.sh related files, and make a PR. Does this sound okay?

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented May 28, 2020 via email

@MinsukJi-NOAA
Copy link
Collaborator

Minsuk, I'd like to take a look why results are different when using fv3 module. Can you point to me your code for this testing? Thanks

The differences I see between fv3 and fv3_coupled modules are:
netcdf 4.7.0 (fv3_coupled) vs. netcdf_parallel 4.7.4 (fv3)
esmf 8.0.0 (fv3_coupled) vs. esmf 8.0.0_parallelnetcdf (fv3)

On Hera, source code is here: /scratch2/NCEPDEV/stmp3/Minsuk.Ji/s2s-moorthi
Run directory with fv3_coupled module: /scratch1/NCEPDEV/stmp2/Minsuk.Ji/S2S_RT/rt_210813
Run directory with fv3 module: /scratch1/NCEPDEV/stmp2/Minsuk.Ji/S2S_RT/rt_177612

@SMoorthi-emc
Copy link
Collaborator Author

SMoorthi-emc commented May 28, 2020 via email

@SMoorthi-emc
Copy link
Collaborator Author

SMoorthi-emc commented May 28, 2020 via email

@MinsukJi-NOAA
Copy link
Collaborator

It appears that your CICE_SRC is not the latest version. May want to try the current NOAA-EMC/CICE5/develop version.

From 468841a to 266ee81?

@SMoorthi-emc
Copy link
Collaborator Author

yes

@DeniseWorthen
Copy link
Collaborator

The current develop branch of cice has not been merged to ufs-s2s yet. I am waiting on the PR reviews.

@SMoorthi-emc
Copy link
Collaborator Author

SMoorthi-emc commented May 28, 2020 via email

@MinsukJi-NOAA
Copy link
Collaborator

I think MOM6_MAKEOPT and CICE_MAKEOPT are not properly set for DEBUG, although esmf8.0.0g is set properly. I will try adding them in compile.sh for DEBUG.

@MinsukJi-NOAA
Copy link
Collaborator

I think MOM6_MAKEOPT and CICE_MAKEOPT are not properly set for DEBUG, although esmf8.0.0g is set properly. I will try adding them in compile.sh for DEBUG.

This seems to have worked. The two debug tests on Hera passed.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented May 28, 2020 via email

@MinsukJi-NOAA
Copy link
Collaborator

Great, thanks Minsuk. So all other tests passed too?

Yeah, all 14 tests passed with fv3_coupled module.

@SMoorthi-emc
Copy link
Collaborator Author

SMoorthi-emc commented May 28, 2020 via email

@MinsukJi-NOAA MinsukJi-NOAA mentioned this pull request Jun 3, 2020
@MinsukJi-NOAA
Copy link
Collaborator

@SMoorthi-emc I opened a PR (#104 ) that includes all your changes, my modifications, and also rt.sh related changes to interface with new compile.sh

@SMoorthi-emc
Copy link
Collaborator Author

Thanks Minsuk. This should lead to unified ufs-s2s-model and ufs-weather-model at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants