-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMEPS to ufs-s2s-model #90
Add CMEPS to ufs-s2s-model #90
Conversation
Feature/add comparisons (#4)
merge develop/ufs-s2s-model
MOM_input template for initial condition files
merge fv3atm/develop
This reverts commit 0c8cb0b.
add appbuilder files for CMEPS
cmeps nems.configure
merge to latest develop
Debug mode capablility (#15)
Add debug compilation flag specification at top level (#17)
update to current ufs-weather-app (#19)
after updating to current ufs-s2s@develop No changes to answers are expected Tests fail only because of the global attribute in MOM6 MOM6 restart files
create it using the date strings; add fixes for restart test
in med_modelio.nml. add cmeps 6h debug test w/ 1hour wall clock
Orion post maintenance fix (ufs-community#102)
run file to setup C96 restart test
Regression tests are currently running on Hera. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments/questions, but overall looks good to me. I'll hit the approve after the regtests all go through.
only used by CIME driver. Add ifdef CMEPS to fv3_coupled for all platforms. Re-order rt.conf so that when executed sequentially, all cold jobs are done first. For restart test, set up to copy restarts from the 'dependent run' directory.
Reran tests w/ changes to nems.configure and adding DEP_RUN variable (currently manually set) in restart test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making changes in restart test. Please remove the tests/output, it seems a temporary file to me.
We may need to discuss on how to start the model later.
Thanks Everyone for your timely reviews. |
Add CMEPS to ufs-s2s-model (ufs-community#90)
This PR adds a second mediator ( CMEPS ) to the ufs-s2s-model:
Adds CMEPS version regression tests for all current NEMS mediator tests (rt.sh). All current NEMS mediator baselines were tested and found identical except for a global attribute difference in the MOM6 restarts (commit 45f515e in this branch).
Adds a restart reproducibility test for CMEPS. A 3 day C96 baseline is created. The 2d C96 is restarted and run for an additional day. Answers are then compared against the 3 day baseline. An rt.conf.restart file is added for convenience since no baseline is created for the restart test.
Updates namelists and nems.configure files for the coupled model to accommodate warm-start restarting of the coupled model
Updates the namelist settings for the restart output directory for MOM6 from MOM6_RESTART to RESTART and the output directory for CICE5 from restart to RESTART. Both are consistent with FV3
Adds two additional configurable settings to MOM_input_template. Default values are consistent with current settings used in ufs-s2s-model. Restart reproducibility requires non-default values until the halo decomposition bug seen when USE_LA_LI2016 = true is fixed.
Updates NEMS to the current develop which contains a fix for CMEPS build for rt.sh and also adds required component.mk for CICE6.
This PR will become active after the associated CICE5 PR: #89
Associated project: 2
Associated issues: #48, #32, #33, #76
Co-author: @mvertens
The following figures show the difference in the ocean surface state and the ice surface state after 10d for a single initial condition date for the NEMS and CMEPS mediators.
The following figures show the difference in the ocean surface state after 10d for a single initial condition date when wave coupling is included.