Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update WW3 to no longer set an ice value for z0 #171

Merged

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

Description of changes

This updates WW3 so that it no longer sets z0 over ice points

Specific notes

In the first round of coupling with WW3 there were two issues noted, the first was that SSTs along coastlines were increasing and the second was temperature over ice had changed significantly. The coastline issue was resolved by @SMoorthi-emc
PR #161 but this further improves (ie. decreases) the change in the surface temperature over ice.

Issues Fixed (include github issue #):

Are changes expected to change answers?

  • bit for bit (no)
  • more substantial (yes)

Specific changes:

  • changes in parm directory (no)
  • changes in module files (no)
  • new tests added or removed (no)

Answers will change for wave tests, new baselines and mod_def input files for WW3 are required.

Testing performed:

  • machines: Orion
  • details: 35 day tests comparing waves to no waves

Hashes used for testing:

  • NEMS: a44b1f7df837cd320d78683717ffd27bcee023d8
  • CMEPS: f52f263a7d1c443e3c3f33fa00590f180d068888
  • FV3: 0e83a92c2e79e3f2fb5894e41efec12ff34be888
  • MOM6: d996f62fc06a3d33ce98943438c8cc84cdacee8c
  • CICE: (CICE5) 59e40edc2240724fca2b40531402ff94b2966540
  • WW3: 9bc7e8ca67c68a2a1b67bffcc0c122d9a0cb335b
  • FMS: f61416fef691d9ba39a40df1ce72aa574f54c390
  • stochastic_physics: a8e2cc1c84a1e6a7deb9eef152edec2992b1a859

The 35 day tests were run on orion for Feb and Aug of 2013.

With waves:
/work/noaa/marine/jmeixner/p5ww3tests/wwaves/COMROOT/wave_022013/gfs.20130201/00
/work/noaa/marine/jmeixner/p5ww3tests/wwaves/COMROOT/wave_Aug2013/gfs.20130801/00

No waves (for comparison):
/work/noaa/marine/jmeixner/p5ww3tests/nowave/COMROOT/nowave_02213/gfs.20130201/00/
/work/noaa/marine/jmeixner/p5ww3tests/nowave/COMROOT/nowave_082013/gfs.20130801/00/

Plots by @LydiaStefanova-NOAA to show changes in SST and surface temp over ice.

This is Feb 2013 of surface temp waves minus no waves, day 1 average on left, 35 day average on right
Screen Shot 2020-08-28 at 3 27 15 PM

This is Aug 2013 of surface temp waves minus no waves, day 1 average on left, 35 day average on right
Screen Shot 2020-08-28 at 3 28 22 PM

This is Feb 2013 of SST, Day 1 average on Left, Days 1-10 on right:

Screen Shot 2020-08-28 at 3 30 59 PM

Aug 2013 of SST, Day 1 average on Left, Days 1-10 on right:
Screen Shot 2020-08-28 at 3 31 38 PM

More analysis can be provided if required.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Related PR for WW3: NOAA-EMC/WW3#248

@junwang-noaa
Copy link
Collaborator

May I ask what is the status of this PR? Is RT done?

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Working on the build script for the WW3 pre/post jobs which needs to be in place for this commit. Having issues with grib on orion. Orion baselines have been created but still need ww3_grib to build

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Sep 3, 2020 via email

@junwang-noaa
Copy link
Collaborator

Jessica, since we do not hear from you about the timeline to get this PR ready, we will go ahead with PR #160. Please let me know if you have questions.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

The WW3 pre/post jobs are needed to build the mod_defs for this commit. I found a sufficient work around for that and have postponed the post build jobs for now. I'm getting ready to move the orion baseline to the official area and can have the hera/wcoss baselines done this evening. I hope I can still push this commit.

@junwang-noaa
Copy link
Collaborator

OK, please go ahead.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@junwang-noaa @DeniseWorthen @binli2337 I have the logs for hera and orion pushed. I messed up the starting point for my baselines somehow with the machine switch for wcoss-dell. I hope I have that sorted out now and will get them pushed up as soon as they are ready. To help the CICE6 PR go through as soon as possible after I made baselines on hera for the wave RTs which would have different answers than what Denise is already working on. I couldn't compile on orion due to a missing library, but when it's there am happy to do the same for Orion and WCOSS (once I finish the ones for this PR).

@junwang-noaa
Copy link
Collaborator

@JessicaMeixner-NOAA Thanks for letting us know. May I ask what is the missing library? Will you add it to the s2s module files? If yes, we may need to add it in weather module files too since we are unifying the two repos.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@junwang-noaa There are no missing libraries for this PR. For CICE6 PR: #160 that @DeniseWorthen is working on, for orion esmflocal/8.1.0.27bs is missing.

@DeniseWorthen
Copy link
Collaborator

On orion, I am using module load esmflocal/8.1.0.27bs.release and module load esmflocal/8.1.0.27bsg.release

I think the "release" will be removed but when I tested yesterday the esmflocal still was using this name.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Sep 4, 2020 via email

@JessicaMeixner-NOAA
Copy link
Collaborator Author

So the cpld_fv3_ccpp_mom6_cice_cmeps_restart test failed on wcoss-dell with:

[270] forrtl: severe (174): SIGSEGV, segmentation fault occurred
[270] Image              PC                Routine            Line        Source
[270] fcst.exe           0000000002C7A1CD  Unknown               Unknown  Unknown
[270] libpthread-2.17.s  00002B50063F8630  Unknown               Unknown  Unknown
[270] fcst.exe           000000000082B33E  ice_gather_scatte        2103  ice_gather_scatter.F90
[270] fcst.exe           000000000078A722  ice_read_write_mp        1123  ice_read_write.F90
[270] fcst.exe           000000000078D75C  ice_restart_mp_re         459  ice_restart.F90
[270] fcst.exe           0000000000790D5A  ice_restart_drive         319  ice_restart_driver.F90
[270] fcst.exe           0000000000651C2C  cice_initmod_mp_i         205  CICE_InitMod.F90

Is this the error that's been previously seen by @binli2337 @DeniseWorthen and others. I'm assuming this also exists in the current develop branch as there's nothing this PR changes that theoretically should effect this.

@DeniseWorthen
Copy link
Collaborator

That is definitely the error I got (issue #164). There is some issue on Dell that is intermittent. We need to resolve this if we don't have a method that works consistently (sequential for example).

@junwang-noaa
Copy link
Collaborator

@JessicaMeixner-NOAA on dell, please do not use ecflow to run RT, try: rt.sh -f

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@junwang-noaa it failed for both ecflow and sequential

@junwang-noaa
Copy link
Collaborator

Let me checkout your PR and give a try

@JessicaMeixner-NOAA
Copy link
Collaborator Author

The 5th+ time was the charm, the restart test has passed this time. A few more tests still need to run on dell, but hopefully all will go okay. I'll push the logs up later this evening or in the morning.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Sep 5, 2020 via email

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Okay, now the debug build is not building from what looks to be a module issue:

Lmod has detected the following error:  Cannot load module "esmf/8.1.0bs21g". At least one of these
module(s) must be loaded:
   Netcdf-parallel

While processing the following module(s):
    Module fullname  Module Filename
    ---------------  ---------------
    esmf/8.1.0bs21g  /gpfs/dell2/emc/modeling/noscrub/emc.nemspara/soft/modulefiles/esmf/8.1.0bs21g

I don't appear to have this issue on Mars, just Venus.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Sep 5, 2020 via email

@JessicaMeixner-NOAA
Copy link
Collaborator Author

All baseline logs have been pushed @junwang-noaa @DeniseWorthen

@junwang-noaa
Copy link
Collaborator

Thanks for getting the RT done.

@DeniseWorthen DeniseWorthen merged commit d7b7081 into ufs-community:develop Sep 7, 2020
ShanSunNOAA pushed a commit to ShanSunNOAA/ufs-s2s-model that referenced this pull request Oct 28, 2020
…-community#171)

* Update CMakeLists.txt to build stochastic_physics
* Update gnumake build to include stochastic_physics wrapper
* Update gnumake build config for macosx.gnu to work with new NCEPLIBS and downgraded FMS
* Update submodule pointer for fv3atm
* Regression test logs for orion.intel, hera.intel, hera.gnu
* Rename rt_stampede_cheyenne.conf to rt_stampede.conf, add rt_cheyenne.conf for cheyenne.intel from NCAR dtc/develop branch
* Regression test logs for wcoss_cray and wcoss_dell_p3
* Revert stochastic_physics change in .gitmodules and update submodule pointer for stochastic_physics
* Revert change to .gitmodules and update submodule pointer for fv3atm
* Revert unintential addition of tests/rt_stochy_ca.conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants