-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update WW3 to no longer set an ice value for z0 #171
update WW3 to no longer set an ice value for z0 #171
Conversation
Related PR for WW3: NOAA-EMC/WW3#248 |
May I ask what is the status of this PR? Is RT done? |
Working on the build script for the WW3 pre/post jobs which needs to be in place for this commit. Having issues with grib on orion. Orion baselines have been created but still need ww3_grib to build |
If I understand correctly, the s2s model does not run any WW3 pre/post
jobs, is it possible that we can first get ww3 with z0 fix in s2s and have
another commit when ww3 pre/post build issue is fixed? If you prefer to do
them in one commit, may I ask the estimated timeline to get this commit in?
If you need more time, can we get CICE6 PR in s2s? Several other
development work are dependent on that PR.
…On Thu, Sep 3, 2020 at 10:07 AM Jessica Meixner ***@***.***> wrote:
Working on the build script for the WW3 pre/post jobs which needs to be in
place for this commit. Having issues with grib on orion. Orion baselines
have been created but still need ww3_grib to build
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TKYXA723RMPL2CO3V3SD6PKJANCNFSM4QOOL5EQ>
.
|
Jessica, since we do not hear from you about the timeline to get this PR ready, we will go ahead with PR #160. Please let me know if you have questions. |
The WW3 pre/post jobs are needed to build the mod_defs for this commit. I found a sufficient work around for that and have postponed the post build jobs for now. I'm getting ready to move the orion baseline to the official area and can have the hera/wcoss baselines done this evening. I hope I can still push this commit. |
OK, please go ahead. |
@junwang-noaa @DeniseWorthen @binli2337 I have the logs for hera and orion pushed. I messed up the starting point for my baselines somehow with the machine switch for wcoss-dell. I hope I have that sorted out now and will get them pushed up as soon as they are ready. To help the CICE6 PR go through as soon as possible after I made baselines on hera for the wave RTs which would have different answers than what Denise is already working on. I couldn't compile on orion due to a missing library, but when it's there am happy to do the same for Orion and WCOSS (once I finish the ones for this PR). |
@JessicaMeixner-NOAA Thanks for letting us know. May I ask what is the missing library? Will you add it to the s2s module files? If yes, we may need to add it in weather module files too since we are unifying the two repos. |
@junwang-noaa There are no missing libraries for this PR. For CICE6 PR: #160 that @DeniseWorthen is working on, for orion esmflocal/8.1.0.27bs is missing. |
On orion, I am using module load esmflocal/8.1.0.27bs.release and module load esmflocal/8.1.0.27bsg.release I think the "release" will be removed but when I tested yesterday the esmflocal still was using this name. |
Yes, the esmf lib convention on orion does not change yet.
…On Fri, Sep 4, 2020 at 10:35 AM Denise Worthen ***@***.***> wrote:
On orion, I am using module load esmflocal/8.1.0.27bs.release and module
load esmflocal/8.1.0.27bsg.release
I think the "release" will be removed but when I tested yesterday the
esmflocal still was using this name.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TJLUF53J3OLG5PQFSDSED3J3ANCNFSM4QOOL5EQ>
.
|
So the cpld_fv3_ccpp_mom6_cice_cmeps_restart test failed on wcoss-dell with:
Is this the error that's been previously seen by @binli2337 @DeniseWorthen and others. I'm assuming this also exists in the current develop branch as there's nothing this PR changes that theoretically should effect this. |
That is definitely the error I got (issue #164). There is some issue on Dell that is intermittent. We need to resolve this if we don't have a method that works consistently (sequential for example). |
@JessicaMeixner-NOAA on dell, please do not use ecflow to run RT, try: rt.sh -f |
@junwang-noaa it failed for both ecflow and sequential |
Let me checkout your PR and give a try |
The 5th+ time was the charm, the restart test has passed this time. A few more tests still need to run on dell, but hopefully all will go okay. I'll push the logs up later this evening or in the morning. |
The restart test also passed in my RT test. The PR is running very slow, so
far 12 tests have run and they all ran successfully.
…On Fri, Sep 4, 2020 at 7:54 PM Jessica Meixner ***@***.***> wrote:
The 5th+ time was the charm, the restart test has passed this time. A few
more tests still need to run on dell, but hopefully all will go okay. I'll
push the logs up later this evening or in the morning.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPKTGXJZIHSW6Z6D4DSEF42JANCNFSM4QOOL5EQ>
.
|
Okay, now the debug build is not building from what looks to be a module issue:
I don't appear to have this issue on Mars, just Venus. |
It is fixed. I am running RT again too.
…On Sat, Sep 5, 2020 at 11:41 AM Jessica Meixner ***@***.***> wrote:
Okay, now the debug build is not building from what looks to be a module
issue:
Lmod has detected the following error: Cannot load module "esmf/8.1.0bs21g". At least one of these
module(s) must be loaded:
Netcdf-parallel
While processing the following module(s):
Module fullname Module Filename
--------------- ---------------
esmf/8.1.0bs21g /gpfs/dell2/emc/modeling/noscrub/emc.nemspara/soft/modulefiles/esmf/8.1.0bs21g
I don't appear to have this issue on Mars, just Venus.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TOMW2WPZZVCZKVEBKLSEJL2XANCNFSM4QOOL5EQ>
.
|
All baseline logs have been pushed @junwang-noaa @DeniseWorthen |
Thanks for getting the RT done. |
…-community#171) * Update CMakeLists.txt to build stochastic_physics * Update gnumake build to include stochastic_physics wrapper * Update gnumake build config for macosx.gnu to work with new NCEPLIBS and downgraded FMS * Update submodule pointer for fv3atm * Regression test logs for orion.intel, hera.intel, hera.gnu * Rename rt_stampede_cheyenne.conf to rt_stampede.conf, add rt_cheyenne.conf for cheyenne.intel from NCAR dtc/develop branch * Regression test logs for wcoss_cray and wcoss_dell_p3 * Revert stochastic_physics change in .gitmodules and update submodule pointer for stochastic_physics * Revert change to .gitmodules and update submodule pointer for fv3atm * Revert unintential addition of tests/rt_stochy_ca.conf
Description of changes
This updates WW3 so that it no longer sets z0 over ice points
Specific notes
In the first round of coupling with WW3 there were two issues noted, the first was that SSTs along coastlines were increasing and the second was temperature over ice had changed significantly. The coastline issue was resolved by @SMoorthi-emc
PR #161 but this further improves (ie. decreases) the change in the surface temperature over ice.
Issues Fixed (include github issue #):
Are changes expected to change answers?
Specific changes:
Answers will change for wave tests, new baselines and mod_def input files for WW3 are required.
Testing performed:
Hashes used for testing:
The 35 day tests were run on orion for Feb and Aug of 2013.
With waves:
/work/noaa/marine/jmeixner/p5ww3tests/wwaves/COMROOT/wave_022013/gfs.20130201/00
/work/noaa/marine/jmeixner/p5ww3tests/wwaves/COMROOT/wave_Aug2013/gfs.20130801/00
No waves (for comparison):
/work/noaa/marine/jmeixner/p5ww3tests/nowave/COMROOT/nowave_02213/gfs.20130201/00/
/work/noaa/marine/jmeixner/p5ww3tests/nowave/COMROOT/nowave_082013/gfs.20130801/00/
Plots by @LydiaStefanova-NOAA to show changes in SST and surface temp over ice.
This is Feb 2013 of surface temp waves minus no waves, day 1 average on left, 35 day average on right

This is Aug 2013 of surface temp waves minus no waves, day 1 average on left, 35 day average on right

This is Feb 2013 of SST, Day 1 average on Left, Days 1-10 on right:
Aug 2013 of SST, Day 1 average on Left, Days 1-10 on right:

More analysis can be provided if required.