Change grib2 file name forecast hour precision from two to three digits #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… three values instead of two
…n plotting script.
…t hour formats in post filenames
JeffBeck-NOAA
requested review from
BenjaminBlake-NOAA,
gsketefian,
JulieSchramm,
mkavulich and
RatkoVasic-NOAA
JeffBeck-NOAA
changed the title
gsketefian
reviewed
Aug 28, 2020
scripts/exregional_run_post.sh
Outdated
| # | ||
| len_fhr=${#fhr} | ||
| if [ ${len_fhr} -eq 2 ]; then | ||
| post_fhr=${fhr} |
There was a problem hiding this comment.
Line 220: Indent 2 spaces
There was a problem hiding this comment.
Fixed in latest commit.
gsketefian
reviewed
Aug 28, 2020
scripts/exregional_run_post.sh
Outdated
| post_fhr="${fhr:1}" | ||
| fi | ||
| else | ||
| print_err_msg_exit "\ |
There was a problem hiding this comment.
Line 226: Indent two spaces (but not lines 227 and 228!)
There was a problem hiding this comment.
Fixed in latest commit.
christinaholtNOAA
pushed a commit
to christinaholtNOAA/regional_workflow
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Changes forecast hour precision from two to three digits, and adds an "f" prior to the forecast hour in the final grib2 file names. Requested by GSL.
Modifies the plot_allvars.py Python script to match this convention.
TESTS CONDUCTED:
Tested successfully on Hera with both HRRR3km and HRRR25km domains.
CONTRIBUTORS (optional):
@gsketefian