Rename SAR to LAM and JP to ESG, remove fix files #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id. Remove fix files in regional_workflow and source from fix_am and EMC_post.
JeffBeck-NOAA
requested review from
BenjaminBlake-NOAA,
gsketefian,
JulieSchramm,
mkavulich and
RatkoVasic-NOAA
|
@JeffBeck-NOAA Just out of curiosity, what platform did you run the tests on? I can run the end-to-end test suite on either Jet or Hera, whichever you did not test; that should be sufficient to check that all the renaming was done successfully. |
|
@mkavulich I tested on Hera (just updated the PR message). If you can run on Jet, that'd be appreciated! |
mkavulich
changed the title
mkavulich
approved these changes
Aug 18, 2020
christinaholtNOAA
pushed a commit
to christinaholtNOAA/regional_workflow
that referenced
this pull request
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This PR replaces all references to FV3-SAR or SAR-FV3 with FV3-LAM, and JPgrid with ESGgrid. Note that certain directory paths used by EMC or other code developers that reference FV3-SAR could not be changed, so their references in the workflow files are left as is.
All fix files have now been removed from regional_workflow, since they can be sourced from the FIXgsm or the UPP repository directly.
TESTS CONDUCTED:
End-to-end tests on Hera succeeded for the 25-km CONUS domain using the FV3_GSD_SAR and FV3_GFS_2017_gfdlmp SDFs.
ISSUE (optional):
These changes resolve issues #252 and #262.