PBL and Convection and Microphysics update for HR2 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qingfu-Liu
requested review from
JongilHan66,
grantfirl,
dustinswales and
lisa-bengtsson
as code owners
|
I have compiled the code with two suites (FV3_GFS_v16, FV3_GFS_v17_p8) and successfully run two tests (control_c384, control_p8). |
physics/satmedmfvdifq.F
Outdated
| ! tem2 = (u1(i,1)/dz)**2 | ||
| ! tem2 = tem2+(v1(i,1)/dz)**2 | ||
| ! tem2 = cs0*sqrt(e2(i,n))*sqrt(tem2) | ||
| ! |
There was a problem hiding this comment.
You may want to consider removing the lines that are commented out.
lisa-bengtsson
approved these changes
Apr 24, 2023
|
***@***.***, thanks, just removed the comment lines.*
…On Mon, Apr 24, 2023 at 6:33 AM lisa-bengtsson ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good, the reduction of the dry bias is a welcomed contribution.
—
Reply to this email directly, view it on GitHub
<#65 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6UQDIQ6RRVP7KNUI3K3XCZJG7ANCNFSM6AAAAAAXHIRMFU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
JongilHan66
approved these changes
Apr 24, 2023
JiliDong-NOAA
approved these changes
Apr 24, 2023
grantfirl
reviewed
Apr 24, 2023
physics/samfdeepcnv.f
Outdated
| @@ -975,7 +979,29 @@ subroutine samfdeepcnv_run (im,km,first_time_step,restart, & | |||
| endif | |||
| enddo | |||
| endif | |||
|
|
|||
| ! | |||
| ! if tkemean>tkcrt, tem=1+tkemean/tkcrt, clamt=tem*clam | |||
There was a problem hiding this comment.
Consider removing these commented lines for cleaner code.
grantfirl
reviewed
Apr 24, 2023
physics/samfshalcnv.f
Outdated
| @@ -893,6 +895,18 @@ subroutine samfshalcnv_run(im,km,itc,ntc,cliq,cp,cvap, & | |||
| endif | |||
| endif | |||
| enddo | |||
| ! | |||
| ! if tkemean>tkcrt, clamt=(1+tkemean/tkcrt)*clam | |||
There was a problem hiding this comment.
Consider removing the commented code.
grantfirl
reviewed
Apr 24, 2023
physics/satmedmfvdifq.F
Outdated
| @@ -1336,7 +1360,8 @@ subroutine satmedmfvdifq_run(im,km,ntrac,ntcw,ntrw, & | |||
| ptem2 = ptem2 + ptem | |||
| ! | |||
| ! tem2 = stress(i)*spd1(i)/zl(i,1) | |||
| tem2 = stress(i)*ustar(i)*phim(i)/(vk*zl(i,1)) | |||
| ! tem2 = stress(i)*ustar(i)*phim(i)/(vk*zl(i,1)) | |||
There was a problem hiding this comment.
Consider removing commented code. Old versions will always be saved in git history.
|
@Qingfu-Liu Are you going to open PRs into fv3atm and ufs-weather-model for this? |
|
@grant Firl - NOAA Affiliate ***@***.***> , Thanks for your
suggestions, I will remove the comment lines. I will open PRs for fv3atm
and ufs-weather-model.
…On Mon, Apr 24, 2023 at 3:20 PM Grant Firl ***@***.***> wrote:
@Qingfu-Liu <https://github.com/Qingfu-Liu> Are you going to open PRs
into fv3atm and ufs-weather-model for this?
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6UW2QLUFIHQEUOUF4VLXC3HANANCNFSM6AAAAAAXHIRMFU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I just received an e-mail from microphysics developer, he want to make some small changes for HR2, I may combine the code changes to this PR if there is only a small code changes |
|
Ruiyu Sun made small changes to "radiation_clouds.f", and I added him to review the new commit. There are no changes to the existing PR#65 |
RuiyuSun
approved these changes
Apr 26, 2023
Qingfu-Liu
changed the title
37 tasks
37 tasks
dustinswales
reviewed
May 2, 2023
physics/satmedmfvdifq.F
Outdated
| @@ -1664,8 +1687,7 @@ subroutine satmedmfvdifq_run(im,km,ntrac,ntcw,ntrw, & | |||
| endif | |||
| if((pcnvflg(i) .or. scuflg(i)) .and. | |||
| & (k >= kbx .and. k <= kmx)) then | |||
| dz = zi(i,k+1) - zi(i,k) | |||
| tem = f1(i,k) * dz | |||
| tem = f1(i,k) * del(i,k) / grav | |||
There was a problem hiding this comment.
It looks like there is a 1/g local variable declared in this routine. Please replace the division by "grav" with the multiplication by "gravi".
dustinswales
approved these changes
May 2, 2023
physics/satmedmfvdifq.F
Outdated
| @@ -1720,8 +1742,7 @@ subroutine satmedmfvdifq_run(im,km,ntrac,ntcw,ntrw, & | |||
| enddo | |||
| do k = 1,km | |||
| do i = 1,im | |||
| dz = zi(i,k+1) - zi(i,k) | |||
| tem = f1(i,k) * dz | |||
| tem = f1(i,k) * del(i,k) / grav | |||
|
Thanks. I will change it to multiplication
…On Tue, May 2, 2023 at 12:46 PM dustinswales ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good. Nice job. Just a small suggestion on using a constant in one
of the modules.
------------------------------
In physics/satmedmfvdifq.F
<#65 (comment)>
:
> @@ -1720,8 +1742,7 @@ subroutine satmedmfvdifq_run(im,km,ntrac,ntcw,ntrw, &
enddo
do k = 1,km
do i = 1,im
- dz = zi(i,k+1) - zi(i,k)
- tem = f1(i,k) * dz
+ tem = f1(i,k) * del(i,k) / grav
ditto
—
Reply to this email directly, view it on GitHub
<#65 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6URYOZCGVZVX2MEGCS3XEE25RANCNFSM6AAAAAAXHIRMFU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Tests are done at ufs-community/ufs-weather-model#1731. @grantfirl @dustinswales Can you go ahead to merge this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created for HR2 with the updated PBL & convection codes (code from Jongil Han and Ruiyu Sun). I have resolved the conflicts of the codes with the current repository. The overall features for the updates:
to reduce the negative hurricane intensity biases, a parameterization for environmental wind shear effect is included in the GFS cumulus convection and TKE-EDMF PBL schemes. In addition, the entrainment rates in the GFS cumulus convection and TKE-EDMF PBL schemes are enhanced proportional to the sub-cloud or PBL mean TKE (turbulent kinetic energy) when TKE is larger than a threshold value.
A detailed description and test results with the NCEP GFS for the impacts of the new parameterization of environmental wind shear effect and TKE-dependent entrainment enhancement on hurricane intensity and track forecasts are given here.
To enhance the underestimated CAPE forecasts in the GFS, the entrainment rate in the TKE-EDMF PBL scheme is increased as a function of vegetation fraction and surface roughness length. A detailed description and test results with the NCEP GFS for this update are given here.