Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RRTMGP refactoring #34

Merged
merged 26 commits into from
Feb 7, 2023

Conversation

dustinswales
Copy link
Collaborator

@dustinswales dustinswales commented Jan 18, 2023

This PR contains changes to the RRTMGP physics.

  • Major refactoring of RRTMGP interstitials. collapse all rrtmgp_lw(sw) scheme files into rrtmgp_lw(sw)_main schemes. This reduces the number of Interstitial fields needed by the GP scheme and allows us to use the rte-rrtmgp submodule directly, w/o the need for a special branch containing the CCPP hooks.
  • For longwave radiation calculation, add "blocking" capability to main loop.
  • Fix bug in coupling of RRTMGP shortwave radiation to surface.
  • CMake cleanup.

@grantfirl
Copy link
Collaborator

@dustinswales I'm finished looking through this. Looks fine to me for the most part, with some worries about uninitialized intent(out) variables. It seems like every small scheme that was deleted ended up in the SW or LW main schemes? It's a little difficult to follow code moving between files in the GitHub interface (without looking really hard).

@dustinswales
Copy link
Collaborator Author

@dustinswales I'm finished looking through this. Looks fine to me for the most part, with some worries about uninitialized intent(out) variables. It seems like every small scheme that was deleted ended up in the SW or LW main schemes? It's a little difficult to follow code moving between files in the GitHub interface (without looking really hard).

@grantfirl Thanks for your review. I addressed your concerns about the intent of some variables.

I admit this is hard to follow, my apologizes, it's a total restructuring of how GP is implemented in the CCPP.

@jkbk2004
Copy link

jkbk2004 commented Feb 1, 2023

We are about to start working on ufs-community/ufs-weather-model#1571. @dustinswales can you mark out unsolved conversations?

@ChunxiZhang-NOAA ChunxiZhang-NOAA merged commit fb066dd into ufs-community:ufs/dev Feb 7, 2023
@dustinswales dustinswales deleted the rrtmgp_refactor branch March 15, 2023 17:42
dustinswales pushed a commit that referenced this pull request Nov 2, 2023
dustinswales pushed a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants