-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RRTMGP refactoring #34
RRTMGP refactoring #34
Conversation
@dustinswales I'm finished looking through this. Looks fine to me for the most part, with some worries about uninitialized intent(out) variables. It seems like every small scheme that was deleted ended up in the SW or LW main schemes? It's a little difficult to follow code moving between files in the GitHub interface (without looking really hard). |
@grantfirl Thanks for your review. I addressed your concerns about the intent of some variables. I admit this is hard to follow, my apologizes, it's a total restructuring of how GP is implemented in the CCPP. |
We are about to start working on ufs-community/ufs-weather-model#1571. @dustinswales can you mark out unsolved conversations? |
This PR contains changes to the RRTMGP physics.