Add and modify module files for AWS #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me check on this.
…On Fri, Apr 26, 2024 at 9:05 AM GeorgeGayno-NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In build_all.sh
<#937 (comment)>
:
> @@ -27,17 +29,16 @@ if [[ "$target" == "linux.*" || "$target" == "macosx.*" ]]; then
set -x
else
set +x
- source "${DIR_ROOT}/sorc/machine-setup.sh"
if [[ "${target}" == "noaacloud" ]]; then
Why can't these module use/loads be placed in the
"build.noaacloud.intel.lua". For example, see "build.hercules.intel.lua".
—
Reply to this email directly, view it on GitHub
<#937 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMCH62M5E57XP2VXEDDJETY7JUMRAVCNFSM6AAAAABGZSUYA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRVGI3TEMJVGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…ld.noaacloud module
|
thank you
…On Fri, Apr 26, 2024 at 12:32 PM GeorgeGayno-NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In build_all.sh
<#937 (comment)>
:
> @@ -27,17 +29,16 @@ if [[ "$target" == "linux.*" || "$target" == "macosx.*" ]]; then
set -x
else
set +x
- source "${DIR_ROOT}/sorc/machine-setup.sh"
if [[ "${target}" == "noaacloud" ]]; then
Changes at 90e210c
<90e210c>
look good.
—
Reply to this email directly, view it on GitHub
<#937 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMCH6ZSP43KPEZJOJ3E3HLY7KMU5AVCNFSM6AAAAABGZSUYA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRVGY2DIMZSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
PW_CSP is not needed in build_all.sh.
I have removed it, pushed the change in, and test compiled on hear, and aws.
…On Fri, Apr 26, 2024 at 12:38 PM GeorgeGayno-NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On build_all.sh
<#937 (comment)>
:
Is the PW_CSP variable used for compiling on the cloud? I don't see where
it is used.
—
Reply to this email directly, view it on GitHub
<#937 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMCH6373NEMADCWEN5T2VDY7KNLZAVCNFSM6AAAAABGZSUYA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRVGY2TGNJRHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Branch at 2e427c5 was successfully compiled using Intel on Hercules, WCOSS2, Orion, Jet and Hera. |
|
@weihuang-jedi - Looks good. Any other changes? Otherwise, I will merge. |
|
No more changes. Thank you. |
GeorgeGayno-NOAA
approved these changes
Apr 26, 2024
|
It seems OK for now.
Without PW_CSP in build_all.sh, it worked fine on AWS.
I can see:
***@***.***:/contrib/Wei.Huang/dev/ufs-utils-cloud]$ git diff
sorc/machine-setup.sh
diff --git a/sorc/machine-setup.sh b/sorc/machine-setup.sh
index 9d72676..62db25a 100644
--- a/sorc/machine-setup.sh
+++ b/sorc/machine-setup.sh
@@ -94,6 +94,7 @@ elif [[ -d /data/prod ]] ; then
target=s4
module purge
elif [[ "$(dnsdomainname)" =~ "pw" ]]; then
+ echo "PW_CSP: ${PW_CSP}"
if [[ "${PW_CSP}" == "aws" ]]; then # TODO: Add other CSPs here.
target=noaacloud
module purge
***@***.***:/contrib/Wei.Huang/dev/ufs-utils-cloud]$ source
sorc/machine-setup.sh
PW_CSP: aws
So ,machine-setup can still catch the env. var. PW_CSP, and I tried compile
on AWS, it works fine.
…On Mon, Apr 29, 2024 at 8:54 AM GeorgeGayno-NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On build_all.sh
<#937 (comment)>
:
I now see that PW_CSP is used by ./sorc/machine_setup.sh. Does it need to
be retained? I just merged this PR. Should I back out the merge?
—
Reply to this email directly, view it on GitHub
<#937 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMCH665CYCPHUZWT2MCDYLY7ZNIXAVCNFSM6AAAAABGZSUYA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRYG42DQOBWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and modify module files for AWS, as in issue: #936
TESTS CONDUCTED:
ISSUE:
Fixes #936