Addition of an example unit test for users to learn from #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/unit_test_example Conflicts: sorc/chgres_cube.fd/grib2_util.F90
…feature/unit_test_example
…aReames-NOAA/UFS_UTILS into feature/unit_test_example
JeffBeck-NOAA
approved these changes
Oct 6, 2021
@LarissaReames-NOAA Let's close out this PR next. Then I will finish my review of #572 next week (I promise). |
GeorgeGayno-NOAA
requested changes
Oct 19, 2021
There was a problem hiding this comment.
@LarissaReames-NOAA When I click on 'files changes', it shows your surface regridding changes as not part of 'develop' (and the GNU compiler changes are not in 'develop' either). Check how you did your merge from 'develop' to your branch.
LarissaReames-NOAA
force-pushed
the
feature/unit_test_example
branch
from
1eb06f2 to
cee9177
Compare
Fixed. |
GeorgeGayno-NOAA
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Users who are new to unit tests were frequently asking for assistance on how to get started. We decided to add in both instructions on how to do this, and to provide a very simple, well-commented unit test for users to learn from and modify.
TESTS CONDUCTED:
A new unit tests was created and it passes. All system tests pass. Baseline updates not necessary.
DEPENDENCIES:
N/A
DOCUMENTATION:
Added text to the README file in the tests directory to point users towards the new unit test.
ISSUE:
Addresses Issue #573.