Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding orog gsl to orog mask tools #273

Merged
merged 23 commits into from
Apr 9, 2021
Merged

Adding orog gsl to orog mask tools #273

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
48046f5
First step toward adding gsl drag suite oro_data file creation
mdtoyNOAA Feb 3, 2021
b0029c8
Added 'orog_gsl.fd' for creation of orographic static files required …
mdtoyNOAA Feb 9, 2021
2086561
Updated netCDF calls to Fortran90 standard
mdtoyNOAA Feb 12, 2021
ff9fc11
Cleaned up doxygen entries
mdtoyNOAA Feb 12, 2021
a95c670
Merge branch 'develop' of https://github.com/NOAA-EMC/UFS_UTILS into …
mdtoyNOAA Feb 12, 2021
5170ce1
Added error management features to code
mdtoyNOAA Feb 20, 2021
b2209d7
Merge branch 'develop' of https://github.com/NOAA-EMC/UFS_UTILS into …
mdtoyNOAA Feb 20, 2021
5b1f52e
Updated gsl_oro_data program and modules to automatically differentia…
mdtoyNOAA Mar 12, 2021
31fe141
Added testing of gsl orog_data maker to driver_grid.hera script sequence
mdtoyNOAA Mar 16, 2021
7e4f7d0
Merge branch 'develop' of https://github.com/NOAA-EMC/UFS_UTILS into …
mdtoyNOAA Mar 16, 2021
8aa2f5e
Merge branch 'develop' of https://github.com/NOAA-EMC/UFS_UTILS into …
mdtoyNOAA Mar 18, 2021
9262b9a
Clear doxygen warnings from ./orog_gsl.fd
GeorgeGayno-NOAA Mar 19, 2021
1c6c9d4
Merge branch 'adding_orog_gsl_to_orog_mask_tools' of https://github.c…
mdtoyNOAA Mar 19, 2021
0f28810
Added doxygen comments to orog_gsl.fd Fortran code
mdtoyNOAA Mar 19, 2021
9cd0f8e
Added details about orientations of directional variables in orog_gsl…
mdtoyNOAA Mar 19, 2021
673d382
Added flag 'make_gsl_orog' so the user can create extra 'orog' files …
mdtoyNOAA Mar 22, 2021
6dced69
Add regression test for regional grid that uses GSL GWD
GeorgeGayno-NOAA Mar 22, 2021
c6cebae
Add regression test to Orion.
GeorgeGayno-NOAA Mar 22, 2021
a10f6c6
Fixed Fortran orog stats code such that out-of-bounds array indices a…
mdtoyNOAA Mar 23, 2021
67d704b
Merge branch 'develop' of https://github.com/NOAA-EMC/UFS_UTILS into …
mdtoyNOAA Mar 23, 2021
a6c2b29
Update regression test driver scripts for Cray and Dell.
GeorgeGayno-NOAA Mar 23, 2021
810dc07
Update jet driver script for new regression test.
GeorgeGayno-NOAA Mar 24, 2021
d94441f
Merge branch 'develop' of https://github.com/NOAA-EMC/UFS_UTILS into …
mdtoyNOAA Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions sorc/orog_mask_tools.fd/orog_gsl.fd/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,6 @@ set(exe_name orog_gsl)
add_executable(${exe_name} ${fortran_src})
target_link_libraries(
${exe_name}
bacio::bacio_4
w3nco::w3nco_d
ip::ip_d
sp::sp_d
NetCDF::NetCDF_Fortran)
if(OpenMP_Fortran_FOUND)
target_link_libraries(${exe_name} OpenMP::OpenMP_Fortran)
endif()

install(TARGETS ${exe_name} RUNTIME DESTINATION ${exec_dir})
43 changes: 23 additions & 20 deletions sorc/orog_mask_tools.fd/orog_gsl.fd/gsl_oro_data.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,28 @@
!> @file
!! @brief Create orographic (oro_data) files for use by GSL drag suite
!!
!! Program GSL_ORO_DATA
!!
!! This program calls subroutines which calculate the parameters
!! required for the GSL subgrid-scale orographic gravity-wave drag (GWDO)
!! suite on the FV3 grid. These parameters are for the small-scale
!! GWD (Tsiringakis et al., 2017) and turbulent orographic form drag (TOFD)
!! (Beljaars et al., 2004) schemes of the GSL drag suite. The output
!! fields are:
!! var, con, ol{1,2,3,4} and oa{1,2,3,4}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make these proper lists? Just use a hyphen, like this:

- var
- con
- etc.

!! or in FV3 parlance:
!! stddev, convexity, ol{1,2,3,4} and oa{1,2,3,4}
!! These variables are output to netCDF.
!!
!! Note: This program works for both the global FV3GFS cubed
!! sphere, i.e., for tiles 1 through 6, and for the
!! regional lam, i.e., for tile 7
!!
!! Author: Michael Toy -- NOAA/GSL January 27, 2021
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the doxygen author and date tags.

!! Based on code by Michael Duda provided by NCAR/MMM
!!
program gsl_oro_data

!--------------------------------------------------------------------
! This program calls subroutines which calculate the parameters
! required for the GSL subgrid-scale orographic gravity-wave drag (GWDO)
! suite on the FV3 grid. These parameters are for the small-scale
! GWD (Tsiringakis et al., 2017) and turbulent orographic form drag (TOFD)
! (Beljaars et al., 2004) schemes of the GSL drag suite. The output
! fields are:
! var, con, ol{1,2,3,4} and oa{1,2,3,4}
! or in FV3 parlance:
! stddev, convexity, ol{1,2,3,4} and oa{1,2,3,4}
! These variables are output to netCDF.
!
! Note: This program works for both the global FV3GFS cubed
! sphere, i.e., for tiles 1 through 6, and for the
! regional lam, i.e., for tile 7
!
! Author: Michael Toy -- NOAA/GSL January 27, 2021
! Based on code by Michael Duda provided by NCAR/MMM
!--------------------------------------------------------------------

use gsl_oro_data_sm_scale, only: calc_gsl_oro_data_sm_scale
use gsl_oro_data_lg_scale, only: calc_gsl_oro_data_lg_scale
use gsl_oro_data_sm_scale_sar, only: calc_gsl_oro_data_sm_scale_sar
Expand Down
Loading