Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doxygen to remaining repository routines. #241

Merged

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

Add basic doxygen to remaining repo routines. Doxygen would not work
with the Fortran include files in orog.fd. So I removed unused include file
resovod.h and converted machine.h to a Fortran module. Update to use
full paths for better online display.

See: https://georgegayno-noaa.github.io/UFS_UTILS/index.html

Resolved #191.

Add doxygen to remaining repo routines.  Removed unused
include file - resovod.h - from orog.fd and convert
machine.h to a fortran module.  Could not get doxygen
to work with fortran include files. Update to use
full paths for better online display.

Issue ufs-community#191.
@GeorgeGayno-NOAA
Copy link
Collaborator Author

One thing I can't figure out. There are routines with the same name in multiple programs. And doxygen creates a single merged file from them. Very confusing. For an example, see model_grid (and go to bottom of page): https://georgegayno-noaa.github.io/UFS_UTILS/classmodel__grid.html

@edwardhartnett
Copy link
Collaborator

I don't (yet) have an answer for the problems of duplicate file names.

However, this still does not complete the issue, though this is great progress. We still need to write a mainpage which the user can use to navigate all these utilities and functions...

doxygen updates per reviewer request.

Issue ufs-community#191.
@GeorgeGayno-NOAA
Copy link
Collaborator Author

I don't (yet) have an answer for the problems of duplicate file names.

However, this still does not complete the issue, though this is great progress. We still need to write a mainpage which the user can use to navigate all these utilities and functions...

Do you want the mainpage as part of this PR? Is there a good example of a mainpage in one of our repos?

Copy link
Collaborator

@edwardhartnett edwardhartnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@GeorgeGayno-NOAA
Copy link
Collaborator Author

After the merge, should I update the official 'gh-pages' branch? I think we forgot to do that after the last few merges.

@edwardhartnett
Copy link
Collaborator

Yes, good idea, please do update them.

The way I do that is to build the code, with --enable-docs, as usual.

Then, I clone another copy of the repo. In that clone I do:

git checkout gh-pages
git status        **<------------------------check to ensure you are on gh-pages branch!**
git rm -rf *
cp -R /other/clone/docs/* .
git add *
git commit -m "updated" -a && git push

*MAKE SURE you are on the gh-pages branch before doing git rm -rf !

On the gh-pages branch, you remove everything, then copy the new html there, then add it. You really want to be sure you are on the gh-pages branch before doing git rm -rf *. I really can't say that enough! ;-)

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 7760027 into ufs-community:develop Jan 12, 2021
@GeorgeGayno-NOAA
Copy link
Collaborator Author

Yes, good idea, please do update them.

The way I do that is to build the code, with --enable-docs, as usual.

Then, I clone another copy of the repo. In that clone I do:

git checkout gh-pages
git status        **<------------------------check to ensure you are on gh-pages branch!**
git rm -rf *
cp -R /other/clone/docs/* .
git add *
git commit -m "updated" -a && git push

*MAKE SURE you are on the gh-pages branch before doing git rm -rf !

On the gh-pages branch, you remove everything, then copy the new html there, then add it. You really want to be sure you are on the gh-pages branch before doing git rm -rf *. I really can't say that enough! ;-)

Done!

@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the feature/doxygen3 branch January 20, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add doxygen documentation
2 participants