Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up land-increment namelist and script variable names. #1022

Merged

Conversation

ClaraDraper-NOAA
Copy link
Contributor

@ClaraDraper-NOAA ClaraDraper-NOAA commented Feb 5, 2025

DESCRIPTION OF CHANGES:

Changed variable names for the land increments to be more consistent. Also added "gcycle_" at the start of several variable names, so that in the global_workflow it is clear that these actions are being requested from UFS_UTILS. This is in preparation for a future PR to global_workflow which will move some of this functionality into the model (using IAU).

TESTS CONDUCTED:

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2). Done using 0d1b2ea.
  • Compile branch on Hera using GNU. Done using 0d1b2ea. global_cycle compiled with no warnings.
  • Compile branch in 'Debug' mode on WCOSS2. Done on Cactus using 0d1b2ea with no warnings.
  • Run unit tests locally on any Tier 1 machine. Done on Hera using 0d1b2ea. All tests passed.
  • Run global_cycle consistency tests locally on all Tier 1 machines. Done using 0d1b2ea. All tests passed as expected.

DEPENDENCIES:

This PR is required for global_workflow PR 3295

DOCUMENTATION:

Note, the Doxygen did not compile correctly, but that is not related to this PR. It will be fixed in #1026.

ISSUE:

Resolves issue 1021

@ClaraDraper-NOAA
Copy link
Contributor Author

Created as a draft, while I run tests in global_workflow.

@ClaraDraper-NOAA
Copy link
Contributor Author

@GeorgeGayno-NOAA I've confirmed this works with my pending global_workflow PR. Its ready to review.

@GeorgeGayno-NOAA GeorgeGayno-NOAA self-requested a review February 6, 2025 20:35
@ClaraDraper-NOAA
Copy link
Contributor Author

@GeorgeGayno-NOAA Is there anything else I need to do to get this merged?

@GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA Is there anything else I need to do to get this merged?

Let me complete the tests on the machines you don't have access to. Then, we can merge.

@GeorgeGayno-NOAA GeorgeGayno-NOAA self-requested a review February 19, 2025 16:00
@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 32fe4c8 into ufs-community:develop Feb 19, 2025
4 checks passed
@ClaraDraper-NOAA
Copy link
Contributor Author

Thanks @GeorgeGayno-NOAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants