Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up fv3gfs_make_orog.sh script #932

Closed
GeorgeGayno-NOAA opened this issue Apr 22, 2024 · 0 comments · Fixed by #938
Closed

Clean up fv3gfs_make_orog.sh script #932

GeorgeGayno-NOAA opened this issue Apr 22, 2024 · 0 comments · Fixed by #938
Assignees
@GeorgeGayno-NOAA
Labels
maintenance Basic upkeep

Comments

@GeorgeGayno-NOAA
Copy link
Collaborator

The script contains options for non FV3 grids, which are no longer supported. Perform some clean up.
@GeorgeGayno-NOAA GeorgeGayno-NOAA added the maintenance Basic upkeep label Apr 22, 2024
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Apr 22, 2024
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 22, 2024
@GeorgeGayno-NOAA
Remove some unused variables from fv3gfs_make_orog.sh and
d9a7547 
move their initialization to the orog program.

Fixes ufs-community#932.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 22, 2024
@GeorgeGayno-NOAA
Remove tile dimensions from the program namelist. Instead
64e67ff 
determine them from the 'grid' file.

Fixes ufs-community#932.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 22, 2024
@GeorgeGayno-NOAA
Update other invocation of orog code in the ocean merge
a95bfb0 
step.

Fixes ufs-community#932.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 25, 2024
Some cleanup to fv3gfs_make_orog.sh.
c4965c5 
Fixes ufs-community#932.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 25, 2024
Change grid driver working directory to avoid conflict
7bf7cf8 
with Orion.

Fixes ufs-community#932.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 26, 2024
Remove unused variable BLAT and associated obsolete functions.
12eec27 
Fixes ufs-community#932.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 26, 2024
Remove some unused variables from mtnlm7_oclsm.F.
3d386be 
Fixes ufs-community#932.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 26, 2024
Add prolog and comments to fv3gfs_make_orog.sh. Remove
329bcc9 
more unused variables.

Fixes ufs-community#932.
@GeorgeGayno-NOAA GeorgeGayno-NOAA mentioned this issue Apr 26, 2024
Merged
5 tasks
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 29, 2024
Merge branch 'develop' into cleanup/oro_script
aa633cd 
Fixes ufs-community#932.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 29, 2024
More clean up to fv3gfs_make_orog.sh
6736707 
Fixes ufs-community#932.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue May 7, 2024
Merge branch 'develop' into cleanup/oro_script
7ac97e8 
Fixes ufs-community#932.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue May 13, 2024
Merge branch 'develop' into cleanup/oro_script
4908673 
Fixes ufs-community#932.
GeorgeGayno-NOAA added a commit that referenced this issue May 13, 2024
@GeorgeGayno-NOAA
Minor cleanup of 'orog' program and its run script (#938)
7034628 
Remove unused namelist variables and functions from orog.fd. 
Adjust all scripts that call orog.fd accordingly. Add prolog,
improve error handling and remove old options from
./ush/fv3gfs_make_orog.sh.

Fixes #932.
BinLiu-NOAA pushed a commit to hafs-community/UFS_UTILS that referenced this issue Jul 10, 2024
@GeorgeGayno-NOAA @BinLiu-NOAA
Minor cleanup of 'orog' program and its run script (ufs-community#938)
3a337bf 
Remove unused namelist variables and functions from orog.fd. 
Adjust all scripts that call orog.fd accordingly. Add prolog,
improve error handling and remove old options from
./ush/fv3gfs_make_orog.sh.

Fixes ufs-community#932.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgeGayno-NOAA GeorgeGayno-NOAA

Labels
maintenance Basic upkeep
Projects
Version 1.14.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor cleanup of 'orog' program and its run script GeorgeGayno-NOAA/UFS_UTILS
1 participant
@GeorgeGayno-NOAA