Update inheritance of several Mobjects from VGroup to VMobject #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR resolves Issue #3, which addresses unnecessary inheritance from VGroup in several Mobjects. I replaced all instances of VGroup inheritance with VMobject to avoid unexpected behavior with operators and grouping functionality, as stated in the issue.
Motivation and Explanation: Why and how do your changes improve the library?
The original use of VGroup was unnecessary and could cause issues with object grouping behaviors. I reviewed the VGroup methods from vectorized_mobject.py and verified that none of the affected Mobjects required VGroup's grouping-specific behaviors.
Further Information and Comments
I'm in the SWE class, so please let me know if something is incorrect. This is my first ever OSC contribution!
Reviewer Checklist