Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about.css #61

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Update about.css #61

merged 3 commits into from
Feb 14, 2019

Conversation

Myhr86
Copy link
Contributor

@Myhr86 Myhr86 commented Feb 3, 2019

Added more padding to OL

Fixes

Please provide a short description of what your change does.

Related Issues

Added more padding to OL
@mirdaki mirdaki self-requested a review February 3, 2019 18:48
Copy link
Member

@mirdaki mirdaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this fix! It solves the issue on Chrome, but it has brought something else to my attention. If you look at the image below, there is a bunch of extra white space between the number and the text on Chrome (left), but not Firefox (right).

Could you also investigate this and see what we can do to resolve it?

image

@Myhr86
Copy link
Contributor Author

Myhr86 commented Feb 3, 2019

I forgot to test it on different browsers. I'll look into that 👍

When reducing the grid-gap with a few px it solved the problem at least in Chrome and Internet Explorer. Not sure about Firefox. This may not be an ideal solution, so feel free to dismiss my these changes :)
Copy link
Member

@mirdaki mirdaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the visual improvement!

To clarify what I mentioned in the last post, there seems to be a problem where sometimes there is extra white space (as highlighted in the picture below.

box

I think updating the text-alignment to justify or something else like that might help. Let me know what you come up with!

@mirdaki
Copy link
Member

mirdaki commented Feb 14, 2019

Hey @Myhr86, I've gone ahead and accepted the pull request. Thank you for the help! It's much appreciated

@mirdaki mirdaki merged commit 8badc45 into ufosc:dev Feb 14, 2019
mirdaki added a commit that referenced this pull request Feb 17, 2019
* Update HTML and CSS for sign in to work more properly

- Added names and values to form elements (for the backend to read)
- Adjusted CSS to be more desirable to a sign in page

* Better alignment of sign-in form with flexbox

* Add JavaScript to communicate with backend for attendance

* updated logo-text.png

* Update links and resources to the new club repos

* New Fonts (#60)

# Fixes

Replaces the Mono fonts with IBM Plex fonts.

## Related Issues

#54

* Remove floats in topnav in favor of floats (#59)

* Removed topnav floats and replaced with flexbox

* Update about.css to fix list spacing (#61)

* Update about.css

Added more padding to OL

* Updated about.css

When reducing the grid-gap with a few px it solved the problem at least in Chrome and Internet Explorer. Not sure about Firefox. This may not be an ideal solution, so feel free to dismiss my these changes :)

* Justify li to not have weird number spacing

* Navbar on small screens, hover over content (#63)

* Navbar on small screens, hover over content

* removed empty div in navbar

* Remove topnav-placeholder everywhere and extra whitespace

* Fix for navbar links not hiding on mobile displays

Had to update a CSS specifier

* Add CREDITS.md file to give credit to other open source projects

* Update descriptions with link to the getting started guide

- Both in the about page and get involved section of the index page
- Also cleaned and implemented a lot of the TODOs

* Remove unfinshed pages before deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants