Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Add HTTPStatusIntToEnum to VaRestLibrary #275

Merged
merged 4 commits into from
Feb 20, 2020
Merged

Add HTTPStatusIntToEnum to VaRestLibrary #275

merged 4 commits into from
Feb 20, 2020

Conversation

trdwll
Copy link
Contributor

@trdwll trdwll commented Feb 20, 2020

image

@ufna ufna self-requested a review February 20, 2020 13:25
Copy link
Owner

@ufna ufna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments:

  1. Let's remove pragma region
  2. Check clang-format (it's not formatted for now, see https://teamcity.ufna.dev/buildConfiguration/UfnaDev_VaRest_ClangFormatCheck/507?buildTab=log&focusLine=3&linesState=70)
  3. namespace/type enums are deprecated. Even if we took it from epics code, let's change it to the enum class.
  4. I think its better to store the Enum in VaRestTypes.h , not the library itself.

@ufna ufna merged commit 06ab9c0 into ufna:develop Feb 20, 2020
@ufna
Copy link
Owner

ufna commented Feb 20, 2020

Thanks, @trdwll !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants