-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): optimize useEditor
and useEditorState
to reduce number of instances created while being performant #5432
#5445
Conversation
…r of instances created while being performant #5432
🦋 Changeset detectedLatest commit: 26ec66a The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I like this approach a lot as it depends on the react hooks lifecycle as little as possible. We were seeing memory leaks in our application because the replaced editor wasn’t destroyed, fwiw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Changes Overview
This addresses an admittedly minor problem where sometimes the editor would reinitialize itself when it did not have to. This now can reuse editor instances that have been created before & re-apply options continously
Implementation Approach
Testing Done
Verification Steps
Additional Notes
Checklist
Related Issues