Changes Needed to Make Code Run at Notre Dame #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is following up on an email exchange I had with @peterjsadowski:
My student (@DayOfThePenguin) and I tried to run this code out of the box, but we ran into two problems:
numpy
array was filled. We didn't do rigorous testing to confirm what was causing the problem, but I suspect that the main issue was that there were multiple statements of the formX = X[:,1:]
, which I believe causes python to make a copy ofX
behind the scenes for assignment. I think multiple instances of copies being made in combination with python garbage collection was leading to the memory exhaustion.pylearn2
objects seem to be different for the version ofpylearn2
used for this code compared to what we have here at Notre Dame. We've installedpylearn2
from the git master branch as of the last month or so. Is it possible that this version ofpylearn2
isn't compatible with the one used to develop this code?Since we only "fixed" one of the files for running the training (and "fixed" is probably too loose of a term--we commented out lines causing crashes until the code ran), then I won't be hurt if you reject this PR. However, I thought it was the easiest way to share with you what changes we needed to make to get things up and running.