Issue/797 draft manager javascript split #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
worth noting - this only passes tests because of a jest bug #799 if tests are run in the sub package, the coverage fails. Waiting for everyone's thoughts before looking at that. |
iturgeon
changed the base branch from
dev/5-snowflake-obsidian
to
dev/6-lapis-lazuli
* Add rule to ignore testing draftmanager.js in package.json
…anager-javascript-split
zachberry
approved these changes
Apr 24, 2019
zachberry
modified the milestones:
6 - Lapis Lazuli: Numeric Questions,
5B - Malachite: Resource Link & Editor Polish
gitnix
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves Draft Manager in IE11 crashes due to arrow function syntax #797