-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 404 page text #392
Comments
Hey! Can I work on this? |
Hi @pvskarthikeya, you are most welcome to do this. The links should probably be changed to:
Feel free to ask any questions you have. |
@JackMorganNZ
EDIT: |
That's interesting, I haven't seen that before. Have you followed the installation instructions here: https://github.com/uccser/cs-field-guide/blob/develop/docs/installation.md I've realised the documentation for using PDF misses the point you will need to fully install Weasyprint, details on this here: http://weasyprint.readthedocs.io/en/latest/install.html However this seems to be caused by creating PDF output, does it work correctly when you run the generation script normally without PDF? Don't worry about testing PDF output for this simple issue. |
Hey! @JackMorganNZ I was able to build. I had to install all the dependencies locally with brew. Edit: Build is complete and the log shows 4 Erros and 1583 Issues. Is this normal? |
Cool! That error log is fine, the error/warning numbers are quadrupled because I presume you are creating student website, student PDF, teacher website, and teacher PDF so our current system outputs errors for each one. The one error is a known issue that is regarding Markdown headers but it's something we are allowing until we finishing building our CSFG generation system (it's intentionally breaking it), and all the warnings are from Weasyprint generation but are fine. So that log is normal (but we hope in the future that normal is 0 errors and 0 warnings! 😄). |
@JackMorganNZ I changed the text to 2.7.1. The links for the anchor tags seems to be the correct ones. What about the 2015 Student Version? Can i change it to 1.9.9. Since, that is what the link points to. Is that okay? |
I would recommend the changing text |
Also forgot to mention the second line '2015 Student Version - v1.9.9` is good as it mentions both the time of release and the version number. |
@JackMorganNZ I just added a PR for this. Please have a look. |
Perfect, thanks @pvskarthikeya. |
Description
The text on the 404 page is outdated and needs to be updated in a way that it won't become out of date.
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the issue.#???
in your description to reference an issue, where???
is the issue number)The text was updated successfully, but these errors were encountered: