Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chisel 3.5 Bump #186

Merged
merged 11 commits into from
Jan 19, 2022
Merged

Chisel 3.5 Bump #186

merged 11 commits into from
Jan 19, 2022

Conversation

abejgonzalez
Copy link
Collaborator

@abejgonzalez abejgonzalez commented Jan 17, 2022

This PR is adapted from #150 and also removes some warnings from elaboration.

Must be merged alongside ucb-bar/chipyard#1060

@hngenc hngenc self-requested a review January 17, 2022 22:37
@hngenc
Copy link
Member

hngenc commented Jan 17, 2022

Just FYI, we added our own def fire(dummy: Int=0): Bool methods to a lot of our own custom bundles.

I'm not sure if those will compile with your latest change

@abejgonzalez
Copy link
Collaborator Author

Just FYI, we added our own def fire(dummy: Int=0): Bool methods to a lot of our own custom bundles.

I'm not sure if those will compile with your latest change

So far this PR seems to generate Verilog properly. Lets see what the CI in Chipyard says.

@abejgonzalez abejgonzalez self-assigned this Jan 18, 2022
@abejgonzalez abejgonzalez changed the title Chisel 3.5 bump [DO NOT MERGE] Chisel 3.5 Bump Jan 18, 2022
@hngenc hngenc changed the base branch from master to dev January 18, 2022 07:12
@hngenc hngenc changed the title [DO NOT MERGE] Chisel 3.5 Bump Chisel 3.5 Bump Jan 19, 2022
@hngenc hngenc merged commit 3e212b7 into dev Jan 19, 2022
@hngenc hngenc deleted the chisel-3.5-bump branch January 19, 2022 02:50
jerryz123 added a commit that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants