Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FireSim paper tests (migrating them from FireSim) #1980

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Aug 7, 2024

Adds the FireSim paper workloads. Additionally, makes modifications to them s.t. they build w/ FireMarshal's mountImg function (so that they don't need sudo to build).

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez self-assigned this Aug 7, 2024
@abejgonzalez abejgonzalez force-pushed the add-firesim-paper-tests branch from 0406838 to 5e1d48a Compare August 7, 2024 23:08
@abejgonzalez abejgonzalez force-pushed the add-firesim-paper-tests branch from 5e1d48a to 7bef462 Compare August 7, 2024 23:09
@abejgonzalez abejgonzalez reopened this Aug 7, 2024
@abejgonzalez abejgonzalez requested a review from jerryz123 August 7, 2024 23:10
@abejgonzalez
Copy link
Contributor Author

Got past the point where CI might fail. Merging.

@abejgonzalez abejgonzalez merged commit 7eb2cc1 into main Aug 8, 2024
110 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants