-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Change default UART FIFO size and combine UART Config fragments #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
approved these changes
Dec 4, 2023
@abejgonzalez Does this have any implications for Firesim? |
abejgonzalez
requested changes
Dec 5, 2023
abejgonzalez
requested changes
Jan 2, 2024
abejgonzalez
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SFTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tapeout chips are using the default
WithUART
config in theAbstractConfig
. InWithUART
, the TX and RX FIFO depth is set to 256, which is an unrealistically large value. Moreover, it makes UART debugging very difficult, since the FIFO is not flushed when chip is under reset.This PR changes the default FIFO depth to 8, which is the value used on FE310.
Additionally, since now we have control over FIFO depth in the
WithUART
config fragment, theWithUARTFIFOEntries
is redundant. This PR changes the code that referencesWithUARTFIFOEntries
toWithUART
.The
WithUARTFIFOEntries
is marked deprecated, and is recommended to be removed in future releases.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?