Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blkdev test #1680

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix blkdev test #1680

merged 1 commit into from
Dec 2, 2023

Conversation

joonho3020
Copy link
Contributor

The block device controller assumes that the incoming requests from the block device driver is aligned to 64B.
This assumption is not met in the baremetal test, resulting in a tilelink assertion to fire.
This PR fixes the baremetal test.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@joonho3020 joonho3020 merged commit 9ae012f into main Dec 2, 2023
52 of 53 checks passed
@jerryz123 jerryz123 deleted the blkdev-test-fix branch January 21, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants