Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/export entities array #394

Merged
merged 4 commits into from
Mar 13, 2023

Conversation

grugna
Copy link
Contributor

@grugna grugna commented Mar 10, 2023

Jira Ticket: PXP-xxxx

  • Remove this line if you've changed the title to (PXP-xxxx): <title>

New Features

Breaking Changes

Bug Fixes

Improvements

  • JSON export returns JSON arrays instead of comma-delimited strings

Dependency updates

Deployment changes

post_example_entities_together(client, submitter, extended_data_fnames)
with pg_driver.session_scope() as s:
case = pg_driver.nodes(md.Case).first()
print("LUCAAAAAA datadict")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this debug log in tests/integration/datadict/submission/test_endpoints.py and tests/integration/datadictwithobjid/submission/test_endpoints.py 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry, totally forgot that.

@paulineribeyre
Copy link
Contributor

CI succeeded in runs #6 and #7

@paulineribeyre paulineribeyre merged commit 46b40d9 into uc-cdis:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants