Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXP-8341 Fetch pay models from DynamoDB #35

Merged
merged 4 commits into from
Oct 21, 2021
Merged

PXP-8341 Fetch pay models from DynamoDB #35

merged 4 commits into from
Oct 21, 2021

Conversation

paulineribeyre
Copy link
Contributor

Jira Ticket: PXP-8341

New Features

  • Fetch pay model data from DynamoDB; temporarily allow fallbacks to the Hatchery configuration file

Improvements

  • Add "Quick start for local development" docs

Deployment changes

  • Add pay-models-dynamodb-table to the Hatchery configuration file to fetch pay model data from DynamoDB
  • Update the Hatchery configuration file pay-models block to change the user field name to user_id

mfshao
mfshao approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only some very minor points

@jawadqur do we want to merge this and rebase our tansitGW branch for testing? or wait a bit?

@paulineribeyre paulineribeyre merged commit 5ac4e00 into feat/ecs Oct 21, 2021
@paulineribeyre paulineribeyre deleted the feat/paymodel-dynamodb branch October 21, 2021 14:57
@mfshao mfshao mentioned this pull request Oct 26, 2021
Merged
This was referenced Nov 3, 2021
Merged
Closed
Closed
Closed
This was referenced Nov 29, 2021
Closed
Merged
Closed
Closed
Merged
This was referenced Dec 10, 2021
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 10, 2022
Merged
Merged
This was referenced Jan 20, 2022
Merged
Closed
This was referenced Jan 27, 2022
Merged
Merged
This was referenced Jan 31, 2022
Merged
Merged
Merged
This was referenced Feb 16, 2022
Closed
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Feb 23, 2022
Merged
This was referenced Mar 7, 2022
Closed
Merged
Merged
This was referenced Mar 21, 2022
Merged
Merged
This was referenced Mar 29, 2022
Closed
Closed
This was referenced Apr 30, 2022
Closed
Closed
This was referenced Jun 23, 2022
Closed
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jul 21, 2022
Open
@PlanXCyborg PlanXCyborg mentioned this pull request Sep 14, 2022
Merged
@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao approved these changes

@jawadqur jawadqur Awaiting requested review from jawadqur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @mfshao