Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PXP-6540): Feat/guppy format arg #106

Merged
merged 13 commits into from
Jan 19, 2021
Merged

(PXP-6540): Feat/guppy format arg #106

merged 13 commits into from
Jan 19, 2021

Conversation

cterrazas2
Copy link
Contributor

@cterrazas2 cterrazas2 commented Jan 6, 2021 •
edited
Loading

See Portal for remainder of PXP-6540 changes.
Due to Graphql limitations, see TECHDEBT.md for further details about this conversion service.

New Features

  • Implemented new query argument "format" for Guppy to support TSV and CSV downloads from Explorer.

Dependency updates

  • Added Papaparse for conversion service

@cterrazas2 cterrazas2 requested a review from mfshao January 6, 2021 02:10
@cterrazas2 cterrazas2 mentioned this pull request Jan 6, 2021
Merged
mfshao
mfshao reviewed Jan 12, 2021
View reviewed changes
mfshao
mfshao reviewed Jan 19, 2021
View reviewed changes
mfshao
mfshao reviewed Jan 19, 2021
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM in general, can you update the version number to 0.10.0 in package.json, do npm i and commit the updated lock file?

This is needed since we need to release a new version through npm

mfshao
mfshao approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@cterrazas2 cterrazas2 merged commit ebf7327 into master Jan 19, 2021
@cterrazas2 cterrazas2 deleted the feat/guppy-format-arg branch January 19, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cterrazas2 @mfshao