Skip to content

Commit

Permalink
less verbose debug logs
Browse files Browse the repository at this point in the history
  • Loading branch information
paulineribeyre committed Jan 24, 2025
1 parent 378823d commit fe277bc
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -209,5 +209,5 @@
}
]
},
"generated_at": "2025-01-09T21:36:04Z"
"generated_at": "2025-01-24T23:21:40Z"
}
11 changes: 7 additions & 4 deletions gen3workflow/app.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from fastapi import FastAPI
import httpx
from importlib.metadata import version
import logging
import os

from cdislogging import get_logger
Expand All @@ -18,22 +19,24 @@ def get_app(httpx_client=None) -> FastAPI:
logger.info("Initializing app")
config.validate()

debug = config["DEBUG"]
log_level = "debug" if debug else "info"

app = FastAPI(
title="Gen3Workflow",
version=version("gen3workflow"),
debug=debug,
debug=config["DEBUG"],
root_path=config["DOCS_URL_PREFIX"],
)

httpx_logger = logging.getLogger("httpx")
httpx_logger.setLevel(logging.WARNING)
app.async_client = httpx_client or httpx.AsyncClient()

app.include_router(ga4gh_tes_router, tags=["GA4GH TES"])
app.include_router(s3_router, tags=["S3"])
app.include_router(storage_router, tags=["Storage"])
app.include_router(system_router, tags=["System"])

# Following will update logger level, propagate, and handlers
log_level = "debug" if config["DEBUG"] else "info"
get_logger("gen3workflow", log_level=log_level)

logger.info("Initializing Arborist client")
Expand Down
2 changes: 1 addition & 1 deletion gen3workflow/config-default.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
##########

HOSTNAME: localhost
DEBUG: false
DEBUG: true
DOCS_URL_PREFIX: /gen3workflow

# override the default Arborist URL; ignored if already set as an environment variable
Expand Down
7 changes: 5 additions & 2 deletions gunicorn.conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,16 @@ def __init__(self, cfg):

self._remove_handlers(logging.getLogger())
cdislogging.get_logger(
None, log_level="debug" if app_config["DEBUG"] else "warn"
# None, log_level="debug" if app_config["DEBUG"] else "warn"
None,
log_level="warn",
)
for logger_name in ["gunicorn", "gunicorn.error", "gunicorn.access"]:
self._remove_handlers(logging.getLogger(logger_name))
cdislogging.get_logger(
logger_name,
log_level="debug" if app_config["DEBUG"] else "info",
# log_level="debug" if app_config["DEBUG"] else "info",
log_level="info",
)


Expand Down

0 comments on commit fe277bc

Please sign in to comment.