AJ's work on for data library #1
Conversation
AlbertSnows
force-pushed
the
users/ajs/dev
branch
from
53de9cc to
4ef2c92
Compare
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
author Albert Snow <[email protected]> 1724698038 -0500 committer Albert Snow <[email protected]> 1725904980 -0500 # This is a combination of 20 commits.tree 4536d9e23c632e2d1db5b6390967d3dc9ac1c129 parent 0aeb863 author Albert Snow <[email protected]> 1724698038 -0500 committer Albert Snow <[email protected]> 1725904756 -0500 # This is a combination of 19 commits. # This is the 1st commit message: add sh # This is the commit message #2: poetry deps # This is the commit message #3: more sh moving # This is the commit message #4: switchin branches # This is the commit message #5: remove # This is the commit message #6: adding read all lists readme change # This is the commit message #7: add delete # This is the commit message #8: fix delete # This is the commit message #9: remove duplicate # This is the commit message #10: param docs # This is the commit message #11: setting up by id endpoints # This is the commit message #12: setting up dal # This is the commit message #13: implementing update list, delete all lists, get list, and read list # This is the commit message #14: formatting # This is the commit message #15: get list by id works # This is the commit message #16: delete by id works # This is the commit message #17: adding upsert list by id # This is the commit message #18: upsert insert works # This is the commit message #19: upsert update works # This is the commit message #20: add sh poetry deps more sh moving switchin branches remove param docs setting up by id endpoints setting up dal implementing update list, delete all lists, get list, and read list get list by id works delete by id works adding upsert list by id upsert update works
AlbertSnows
force-pushed
the
users/ajs/dev
branch
from
01fedf8 to
24957bc
Compare
add route docs
change test update lock for security issue
fix the id put and added patch
decouple behavior update put lists endpoint to handle various forms of data that need to be updated or created
updating dal functions to handle replacing and crating lists better fix upsert fixing tests
update lines to use endpoint lambdas more work to fix tests
fixing dal to use list id fix replacer fix user_id param?
and default auth
updating routes to use name/creator combo
minor name change
adding a test
adding more tests
add authz to blacklist finalizing tests for /lists endpoint
create by id test file
updating routes moving data out of lists adding basic first test for id
Manually testing API, ran into an issue. When I PUT The expected behavior is that updating the content of a list using the |
This is expected behavior currently. The
and also from some previous comments in the PR. |
We should definitely change this. If a user updates a list, the list ID should remain the same. This will create issues when a user attempts to make multiple updates to a list. Each update will require a new ID. If we want to extend and expand this feature to allow users to share their lists (which we do), then updating something like the name will cause all references to the list to break. |
AlbertSnows
changed the title
This is just hosting my changes while I work on adding endpoints, it is not in a ready state and should not be merged without caution.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes