Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI components and polling for zip downloads #906
Add UI components and polling for zip downloads #906
Changes from 15 commits
4224088
4e465f2
cd35e35
5aedd3a
0e71986
86ab1e6
1cfcda9
5c87ec7
c3515d1
8313132
2e8ba71
1f8c5e3
ebbdc36
a8ba691
ffd6fc2
912db88
0d05a32
1b04486
990d7b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause the component stuck in an infinite loop if
uid
is not returned from https://github.com/uc-cdis/data-portal/pull/906/files#diff-1ac68dcc0067af6b35b142c058129318cc50ee20bfa9195afdb3d99f150d9d15R81You can reproduce it now in qa-heal, since the mock auth is turned on, you will be login by default as a test account, which doesn't have
sower
access. The job dispatch request will return as 403 error, and nouid
is returned, but this section of code will repeatly checking withuid=undefined
Better to handle fetched response with HTTP status code, rather than plain text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. I will add some checks for HTTP status code for cases like this. For the
/status
calls, however, the status code from Sower is 200 regardless of job state, so I will have to keep some plain text checks in thereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense! probably only the first call to
/job/dispatch
needs a status code check