env var mapboxApiAccessToken #674
Conversation
| @@ -160,6 +160,7 @@ if [[ "$NODE_ENV" == "dev" || "$NODE_ENV" == "auto" ]]; then | |||
| echo ./node_modules/.bin/webpack-dev-server | |||
| ./node_modules/.bin/webpack-dev-server | |||
| else | |||
| export NODE_OPTIONS='--max-old-space-size=4096' | |||
There was a problem hiding this comment.
this is to allow node to allocate more mem (default is 512MB i think).
we have this in the Dockerfile but don't know why not here. And portal is so fat that it need this to spin up...
There was a problem hiding this comment.
ok, is this related to covid19? if not, can we make a separate PR to merge this to master? this PR will only be merged to branch feat/covid19dashboard for now
There was a problem hiding this comment.
yeah portal on this branch won't start up if don't have this 😞
i guess by adding more into portal eventually the master branch will gonna need this one day
There was a problem hiding this comment.
just adding 1 environment variable triggered this?? 😱
There was a problem hiding this comment.
it sounds unrealistic but 😕
sorry, changed my mind 🤦♀️it shouldn't be at startup because commons that don't use maps should not get a warning all the time haha. We can put the warning in the covid19dashboard/index.jsx file instead |
add MapboxAccessToken env var to portal from cloud-automation