-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/button auth #565
Feat/button auth #565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! 👍
This comment might be out of the scope of your ticket, but if user don't have access to workspace we should also disable/hide the export to workspace
button in data explorer?
Note that this PR only implements the disabling of UI components based on arborist permissions for the big buttons in the navigation bar and the "Export to workspace" button in the explorer But the functionality can be implemented easily for other components by using the redux store's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks cool
PXP-3189 and part of PXP-3508
Disable UI components based on arborist access.
Requires uc-cdis/cloud-automation#959
Needs a new "componentToResourceMapping" block in gitops.json. Example:
When a user logs in, we ask arborist whether this user has access to each resource defined in
componentToResourceMapping
. We send multiple requests to Arborist'sauth/proxy
endpoint.A possible improvement is to expose theWe are not using theauth/resources
endpoint so that we can fetch all the resources the user has access to in a single call.auth/resources
endpoint because it lists all the resources the user has access to, regardless of which actions the user is allowed to perform on the resourceNew Features
Deployment changes
auth/proxy
endpoint