PXP-2464 fix/homepage chart REST API #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branch deployed in https://qingya.planx-pla.net/, now its index page is open to public. |
mfshao
approved these changes
Feb 25, 2019
qingyashu
force-pushed
the
fix/homepage-chart-rest
branch
from
fb6f717 to
9893651
Compare
abgeorge7
reviewed
Feb 27, 2019
src/Login/Login.jsx
Outdated
| @@ -68,7 +78,7 @@ class Login extends React.Component { | |||
| <hr className='login-page__separator' /> | |||
| <div className='body-typo'>{this.props.data.text}</div> | |||
| { | |||
| this.props.providers.map( | |||
| this.props.providers && this.props.providers.map( | |||
There was a problem hiding this comment.
is this necessary to add if you added default props?
There was a problem hiding this comment.
Oh I changed the code yesterday and forgot to commit... let me update that! thanks
abgeorge7
reviewed
Feb 28, 2019
| import './page.less'; | ||
|
|
||
| class IndexPageComponent extends React.Component { | ||
| constructor(props) { | ||
| super(props); | ||
| getProjectsList(); | ||
| getProjectNodeCounts((res) => { |
There was a problem hiding this comment.
I think that this should go in componentDidMount, not the constructor.
https://reactjs.org/docs/react-component.html#constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change homepage chart to hit REST API instead of using relayer, and also enable
publicoption for index page.components.index.homepageChartNodesfor required nodes and chart labels.components.index.public.gitops.json/${APP}.jsontowards using REST API, then relayer-related code could be moved.New Features
components.index.public: true.Breaking Changes
components.index.homepageChartNodesfor required nodes and chart labels.